Commit 9e1b9de

mad-brillerondrejmirtes

authored and

committed

Warn when trying to cover an interface.

1 parent ceea85e commit 9e1b9deCopy full SHA for 9e1b9de

File tree

+18

-1

lines changed

+18

-1

lines changed

Lines changed: 7 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -95,6 +95,13 @@ public function processCovers(`
`95`	`95`	`if ($this->reflectionProvider->hasClass($className)) {`
`96`	`96`	`$class = $this->reflectionProvider->getClass($className);`
`97`	`97`
	`98`	`+ if ($class->isInterface()) {`
	`99`	`+ $errors[] = RuleErrorBuilder::message(sprintf(`
	`100`	`+ '@covers value %s references an interface.',`
	`101`	`+ $fullName`
	`102`	`+ ))->build();`
	`103`	`+ }`
	`104`	`+`
`98`	`105`	`if (isset($method) && $method !== '' && !$class->hasMethod($method)) {`
`99`	`106`	`$errors[] = RuleErrorBuilder::message(sprintf(`
`100`	`107`	`'@covers value %s references an invalid method.',`
`@@ -105,7 +112,6 @@ public function processCovers(`
`105`	`112`	`return $errors;`
`106`	`113`	`} elseif (!isset($method) && $this->reflectionProvider->hasFunction(new Name($className, []), null)) {`
`107`	`114`	`return $errors;`
`108`		`-`
`109`	`115`	`} else {`
`110`	`116`	`$error = RuleErrorBuilder::message(sprintf(`
`111`	`117`	`'@covers value %s references an invalid %s.',`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -45,6 +45,10 @@ public function testRule(): void`
`45`	`45`	`50,`
`46`	`46`	`'The @covers annotation requires a fully qualified name.',`
`47`	`47`	`],`
	`48`	`+ [`
	`49`	`+ '@covers value \DateTimeInterface references an interface.',`
	`50`	`+ 64,`
	`51`	`+ ],`
`48`	`52`	`]);`
`49`	`53`	`}`
`50`	`54`

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -57,3 +57,10 @@ class CoversNotFullyQualified extends \PHPUnit\Framework\TestCase`
`57`	`57`	`class CoversGlobalFunction extends \PHPUnit\Framework\TestCase`
`58`	`58`	`{`
`59`	`59`	`}`
	`60`	`+`
	`61`	`+/**`
	`62`	`+ * @covers \DateTimeInterface`
	`63`	`+ */`
	`64`	`+class CoversInterface extends \PHPUnit\Framework\TestCase`
	`65`	`+{`
	`66`	`+}`

Comments

(0)