Commit 621abb8

committed

Use sprintf instead of new branch to return correct error message

1 parent 1a7f3e1 commit 621abb8Copy full SHA for 621abb8

File tree

-9

lines changed

-9

lines changed

Lines changed: 5 additions & 9 deletions

Original file line number	Diff line number	Diff line change
`@@ -55,17 +55,13 @@ public function processNode(Node $node, Scope $scope): array`
`55`	`55`	`&& ($leftType->isSuperTypeOf($rightType)->yes())`
`56`	`56`	`&& ($rightType->isSuperTypeOf($leftType)->yes())`
`57`	`57`	`) {`
`58`		`- if (strtolower($node->name->name) === 'assertnotequals') {`
`59`		`- return [`
`60`		`- RuleErrorBuilder::message(`
`61`		`- 'You should use assertNotSame() instead of assertNotEquals(), because both values are scalars of the same type',`
`62`		`- )->identifier('phpunit.assertEquals')->build(),`
`63`		`- ];`
`64`		`- }`
`65`		`-`
`66`	`58`	`return [`
`67`	`59`	`RuleErrorBuilder::message(`
`68`		`- 'You should use assertSame() instead of assertEquals(), because both values are scalars of the same type',`
	`60`	`+ sprintf(`
	`61`	`+ 'You should use %s() instead of %s(), because both values are scalars of the same type',`
	`62`	`+ strtolower($node->name->name) === 'assertnotequals' ? 'assertNotSame' : 'assertSame',`
	`63`	`+ $node->name->name,`
	`64`	`+ ),`
`69`	`65`	`)->identifier('phpunit.assertEquals')->build(),`
`70`	`66`	`];`
`71`	`67`	`}`

Comments

(0)