Commit b99ae3d

committed

Inspect columns in embeddables

1 parent 77d3d8e commit b99ae3dCopy full SHA for b99ae3d

File tree

+32

-3

lines changed

+32

-3

lines changed

Lines changed: 0 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -68,9 +68,6 @@ public function processNode(Node $node, Scope $scope): array`
`68`	`68`	`}`
`69`	`69`
`70`	`70`	`$className = $class->getName();`
`71`		`- if ($objectManager->getMetadataFactory()->isTransient($className)) {`
`72`		`- return [];`
`73`		`- }`
`74`	`71`
`75`	`72`	`try {`
`76`	`73`	`$metadata = $objectManager->getClassMetadata($className);`

Lines changed: 15 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -168,6 +168,21 @@ public function testEmbeddedWithWrongTypeHint(): void`
`168`	`168`	`]);`
`169`	`169`	`}`
`170`	`170`
	`171`	`+ public function testEmbeddable(): void`
	`172`	`+ {`
	`173`	`+ $this->analyse([__DIR__ . '/data/Embeddable.php'], []);`
	`174`	`+ }`
	`175`	`+`
	`176`	`+ public function testBrokenEmbeddable(): void`
	`177`	`+ {`
	`178`	`+ $this->analyse([__DIR__ . '/data/BrokenEmbeddable.php'], [`
	`179`	`+ [`
	`180`	`+ 'Property PHPStan\Rules\Doctrine\ORM\BrokenEmbeddable::$one type mapping mismatch: database can contain string\|null but property expects string.',`
	`181`	`+ 16,`
	`182`	`+ ],`
	`183`	`+ ]);`
	`184`	`+ }`
	`185`	`+`
`171`	`186`	`public function testUnknownType(): void`
`172`	`187`	`{`
`173`	`188`	`$this->analyse([__DIR__ . '/data/EntityWithUnknownType.php'], [`

Lines changed: 17 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,17 @@`
	`1`	`+<?php declare(strict_types = 1);`
	`2`	`+`
	`3`	`+namespace PHPStan\Rules\Doctrine\ORM;`
	`4`	`+`
	`5`	`+use Doctrine\ORM\Mapping as ORM;`
	`6`	`+`
	`7`	`+/**`
	`8`	`+ * @ORM\Embeddable()`
	`9`	`+ */`
	`10`	`+class BrokenEmbeddable`
	`11`	`+{`
	`12`	`+ /**`
	`13`	`+ * @ORM\Column(type="string", nullable=true)`
	`14`	`+ * @var string`
	`15`	`+ */`
	`16`	`+ private $one;`
	`17`	`+}`

Comments

(0)