Commit 4497663

nCrazedondrejmirtes

authored and

committed

Mark nullable EntityRepository methods as impure

The result of these functions depends on the underlying database state which can change between multiple invocations. For example: Calling find() or findOneBy() and asserting the result to be null as a precondition of a test will generate false errors later in the test when the underlying record is added and the method is called again See #550

1 parent b1209a3 commit 4497663Copy full SHA for 4497663

File tree

1 file changed

-0

lines changed

stubs
- EntityRepository.stub

1 file changed

-0

lines changed

`‎stubs/EntityRepository.stub‎`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -20,6 +20,7 @@ class EntityRepository implements ObjectRepository`
`20`	`20`	`* @phpstan-param int\|null $lockMode`
`21`	`21`	`* @phpstan-param int\|null $lockVersion`
`22`	`22`	`* @phpstan-return TEntityClass\|null`
	`23`	`+ * @phpstan-impure`
`23`	`24`	`*/`
`24`	`25`	`public function find($id, $lockMode = null, $lockVersion = null);`
`25`	`26`
`@@ -41,6 +42,7 @@ class EntityRepository implements ObjectRepository`
`41`	`42`	`* @phpstan-param array<string, mixed> $criteria The criteria.`
`42`	`43`	`* @phpstan-param array<string, string>\|null $orderBy`
`43`	`44`	`* @phpstan-return TEntityClass\|null`
	`45`	`+ * @phpstan-impure`
`44`	`46`	`*/`
`45`	`47`	`public function findOneBy(array $criteria, ?array $orderBy = null);`
`46`	`48`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 4497663

File tree

1 file changed

1 file changed

`‎stubs/EntityRepository.stub‎`

0 commit comments