Commit 49beaeb

committed

small perf fix

1 parent edaf1ff commit 49beaebCopy full SHA for 49beaeb

File tree

-3

lines changed

-3

lines changed

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -282,8 +282,6 @@ public function findIntersectingChunks(AABB $aabb) : array`
`282`	`282`
`283`	`283`	`public function fillVAOWithGeometry(Chunk $chunk, ChunkRenderData $rd): void`
`284`	`284`	`{`
`285`		`- $floatBuffer = new FloatBuffer();`
`286`		`-`
`287`	`285`	`// load the neighboring chunks`
`288`	`286`	`$leftChunk = $this->chunks[($chunk->x - 1) . ':' . $chunk->y . ':' . $chunk->z] ?? null;`
`289`	`287`	`$rightChunk = $this->chunks[($chunk->x + 1) . ':' . $chunk->y . ':' . $chunk->z] ?? null;`
`@@ -311,6 +309,7 @@ public function fillVAOWithGeometry(Chunk $chunk, ChunkRenderData $rd): void`
`311`	`309`	`$frontChunk ??= $this->emptyChunk;`
`312`	`310`	`$backChunk ??= $this->emptyChunk;`
`313`	`311`
	`312`	`+ $floatBuffer = new FloatBuffer();`
`314`	`313`
`315`	`314`	`// Unfolded cube`
`316`	`315`	`// --- F = Front`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,8 @@ function(PipelineContainer $data, PipelineResources $resources) use($renderTarge`
`101`	`101`	`continue;`
`102`	`102`	`}`
`103`	`103`
`104`		`- if ($cameraData->frustum->isAABBInView($chunk->aabb) === false) {`
	`104`	`+ if (!$cameraData->frustum->isSphereInView($chunk->aabb->getCenter(), $chunk->aabb->width() * 0.5)) {`
	`105`	`+ if ($showFrustum) Debug3DRenderer::aabb(new Vec3(), $chunk->aabb->min + new Vec3(5), $chunk->aabb->max - new Vec3(5), new Vec3(1, 0, 0));`
`105`	`106`	`continue;`
`106`	`107`	`}`
`107`	`108`

Comments

(0)