Fix GH-19792: SCCP causes UAF for return value if both warning and exception are triggered #19793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

nielsdos wants to merge 1 commit into php:PHP-8.3 from nielsdos:fix-19792

Closed

Fix GH-19792: SCCP causes UAF for return value if both warning and exception are triggered #19793

nielsdos wants to merge 1 commit into php:PHP-8.3 from nielsdos:fix-19792

+45 −4

Conversation

nielsdos

Copy link

Member

@nielsdos nielsdos commented Sep 10, 2025

If an exception and a warning (or deprecation) is emitted, then the result is destroyed twice. Use an else if to prevent this. This is tested via zend_test because the deprecation that triggered the original reproducer may disappear in the future.

@nielsdos


 Fix  phpGH-19792 : SCCP causes UAF for return value if both warning and...

bc8e2b2

... exception are triggered
If an exception _and_ a warning (or deprecation) is emitted, then the
result is destroyed twice. Use an `else if` to prevent this.
This is tested via zend_test because the deprecation that triggered the
original reproducer may disappear in the future.

@nielsdos nielsdos linked an issue

Sep 10, 2025

that may be closed by this pull request

SCCP causes UAF for return value if both warning and exception are triggered #19792

Closed