Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

XP_SOCKET XP_SSL (Socket stream modules): Incorrect condition for Win32/Win64 #19798

Open
@EdmondDantes

Description

if (clisock >= 0) {
	if (clisock >= 0) {

This condition will never be true on Windows, because the type php_socket_t is UINT_PTR, and the value -1 will always be greater than zero.

Correct fix: introduce the INVALID_SOCKET constant for both platforms.

⚠️ This issue causes timeout warnings not to be displayed on Windows.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

        AltStyle によって変換されたページ (->オリジナル) /