ext/json: Remove `zend_never_inline` qualifier for `php_json_is_valid_double()` · Issue #18420 · php/php-src · GitHub

Skip to content

ext/json: Remove `zend_never_inline` qualifier for `php_json_is_valid_double()` #18420

Open

Assignees

Labels

Extension: json Feature OS: Windows

Description

opened

on Apr 24, 2025

Description

It seems the MSVC bug has been resolved:

https://developercommunity.visualstudio.com/t/corrupt-optimization-on-arm64-with-Ox-/10102551
https://developercommunity.visualstudio.com/t/Prev-Issue---with-__assume-isnan-/1597317
So should we remove the ifdef?

@cmb69 you know more about Windows than I do, so is this proposal reasonable?

Metadata

Metadata

Assignees

@cmb69
cmb69

Labels

Extension: json Feature OS: Windows

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions