Commit f7b498b

authored

Use true as return types for SplHeap (#13147)

1 parent 474edd6 commit f7b498bCopy full SHA for f7b498b

File tree

3 files changed

+17

-11

lines changed

UPGRADING
ext/spl
- spl_heap.stub.php
- spl_heap_arginfo.h

3 files changed

+17

-11

lines changed

`‎UPGRADING‎`

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -311,6 +311,12 @@ PDO_SQLITE:`
`311`	`311`	`- PGSQL:`
`312`	`312`	`. pg_select, the conditions arguments accepts an empty array and is optional.`
`313`	`313`
	`314`	`+- SPL:`
	`315`	`+ . SplPriorityQueue::insert() and SplPriorityQueue::recoverFromCorruption()`
	`316`	`+ now has a tentative return type of true`
	`317`	`+ . SplHeap::insert() and SplHeap::recoverFromCorruption()`
	`318`	`+ now has a tentative return type of true instead of bool`
	`319`	`+`
`314`	`320`	`- Standard:`
`315`	`321`	`. The internal implementation for rounding to integers has been rewritten`
`316`	`322`	`to be easier to verify for correctness and to be easier to maintain.`

`‎ext/spl/spl_heap.stub.php‎`

Lines changed: 6 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -14,8 +14,8 @@ class SplPriorityQueue implements Iterator, Countable`
`14`	`14`	`/** @tentative-return-type */`
`15`	`15`	`public function compare(mixed $priority1, mixed $priority2): int {}`
`16`	`16`
`17`		`- /** @return true */`
`18`		`- public function insert(mixed $value, mixed $priority) {} // TODO make return type void`
	`17`	`+ /** @tentative-return-type */`
	`18`	`+ public function insert(mixed $value, mixed $priority): true {}`
`19`	`19`
`20`	`20`	`/** @tentative-return-type */`
`21`	`21`	`public function setExtractFlags(int $flags): int {}`
`@@ -66,10 +66,10 @@ public function next(): void {}`
`66`	`66`	`public function valid(): bool {}`
`67`	`67`
`68`	`68`	`/**`
`69`		`- * @return bool`
	`69`	`+ * @tentative-return-type`
`70`	`70`	`* @implementation-alias SplHeap::recoverFromCorruption`
`71`	`71`	`*/`
`72`		`- public function recoverFromCorruption() {} // TODO make return type void`
	`72`	`+ public function recoverFromCorruption(): true {}`
`73`	`73`
`74`	`74`	`/**`
`75`	`75`	`* @tentative-return-type`
`@@ -90,7 +90,7 @@ abstract class SplHeap implements Iterator, Countable`
`90`	`90`	`public function extract(): mixed {}`
`91`	`91`
`92`	`92`	`/** @tentative-return-type */`
`93`		`- public function insert(mixed $value): bool {}`
	`93`	`+ public function insert(mixed $value): true {}`
`94`	`94`
`95`	`95`	`/** @tentative-return-type */`
`96`	`96`	`public function top(): mixed {}`
`@@ -117,7 +117,7 @@ public function next(): void {}`
`117`	`117`	`public function valid(): bool {}`
`118`	`118`
`119`	`119`	`/** @tentative-return-type */`
`120`		`- public function recoverFromCorruption(): bool {}`
	`120`	`+ public function recoverFromCorruption(): true {}`
`121`	`121`
`122`	`122`	`/** @tentative-return-type */`
`123`	`123`	`abstract protected function compare(mixed $value1, mixed $value2): int;`

`‎ext/spl/spl_heap_arginfo.h‎`

Lines changed: 5 additions & 5 deletions

Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit f7b498b

File tree

3 files changed

3 files changed

`‎UPGRADING‎`

`‎ext/spl/spl_heap.stub.php‎`

`‎ext/spl/spl_heap_arginfo.h‎`

0 commit comments