Commit b5817cc

authored

Remove pointless zval_ptr_dtor() calls in userspace stream handling (#19712)

These act on LONGs, so dtor'ing them is pointless.

1 parent 110fae0 commit b5817ccCopy full SHA for b5817cc

File tree

-3

lines changed

-3

lines changed

Lines changed: 0 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -748,9 +748,6 @@ static int php_userstreamop_seek(php_stream *stream, zend_off_t offset, int when`
`748`	`748`	`zend_result call_result = zend_call_method_if_exists(Z_OBJ(us->object), func_name, &retval, 2, args);`
`749`	`749`	`zend_string_release_ex(func_name, false);`
`750`	`750`
`751`		`- zval_ptr_dtor(&args[0]);`
`752`		`- zval_ptr_dtor(&args[1]);`
`753`		`-`
`754`	`751`	`if (call_result == FAILURE) {`
`755`	`752`	`/* stream_seek is not implemented, so disable seeks for this stream */`
`756`	`753`	`stream->flags \|= PHP_STREAM_FLAG_NO_SEEK;`

Comments

(0)