Commit ab99693

authored

Drop misleading comments about undefined behavior (GH-17532)

There is no undefined behavior here. If `BitScan*()` returns zero, the value written to the first parameter is undefined, but we return a reasonable value.

1 parent d6c6675 commit ab99693Copy full SHA for ab99693

File tree

1 file changed

-2

lines changed

Zend
- zend_bitset.h

1 file changed

-2

lines changed

`‎Zend/zend_bitset.h‎`

Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,6 @@ ZEND_ATTRIBUTE_CONST static zend_always_inline int zend_ulong_ntz(zend_ulong num`
`60`	`60`	`#else`
`61`	`61`	`if (!BitScanForward(&index, num)) {`
`62`	`62`	`#endif`
`63`		`- /* undefined behavior */`
`64`	`63`	`return SIZEOF_ZEND_LONG * 8;`
`65`	`64`	`}`
`66`	`65`
`@@ -98,7 +97,6 @@ ZEND_ATTRIBUTE_CONST static zend_always_inline int zend_ulong_nlz(zend_ulong num`
`98`	`97`	`#else`
`99`	`98`	`if (!BitScanReverse(&index, num)) {`
`100`	`99`	`#endif`
`101`		`- /* undefined behavior */`
`102`	`100`	`return SIZEOF_ZEND_LONG * 8;`
`103`	`101`	`}`
`104`	`102`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit ab99693

File tree

1 file changed

1 file changed

`‎Zend/zend_bitset.h‎`

0 commit comments