Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit 471105a

Browse files
Another attempt to fix MSAN nightly on master
1 parent c4c8d6c commit 471105a

File tree

1 file changed

+4
-11
lines changed

1 file changed

+4
-11
lines changed

‎run-tests.php

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -580,22 +580,15 @@ function main(): void
580580
$environment['USE_TRACKED_ALLOC'] = 1;
581581
$environment['SKIP_ASAN'] = 1;
582582
$environment['SKIP_PERF_SENSITIVE'] = 1;
583-
$lsan_options = [];
584583
if ($switch === '--msan') {
585584
$environment['SKIP_MSAN'] = 1;
586-
// use_tls=0 is a workaround for MSAN crashing with "Tracer caught signal 11" (SIGSEGV),
587-
// which seems to be an issue with TLS support in newer glibc versions under virtualized
588-
// environments. Follow https://github.com/google/sanitizers/issues/1342 and
589-
// https://github.com/google/sanitizers/issues/1409 to track this issue.
590-
$lsan_options[] = 'use_tls=0';
585+
$environment['MSAN_OPTIONS'] = 'intercept_tls_get_addr=0';
591586
}
587+
592588
$lsanSuppressions = __DIR__ . '/.github/lsan-suppressions.txt';
593589
if (file_exists($lsanSuppressions)) {
594-
$lsan_options[] = 'suppressions=' . $lsanSuppressions;
595-
$lsan_options[] = 'print_suppressions=0';
596-
}
597-
if (!empty($lsan_options)) {
598-
$environment['LSAN_OPTIONS'] = join(':', $lsan_options);
590+
$environment['LSAN_OPTIONS'] = 'suppressions=' . $lsanSuppressions
591+
. ':print_suppressions=0';
599592
}
600593
break;
601594
case '--repeat':

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /