Commit 11ea995

committed

curl: Remove incorrect string release on error

The string is owned by the caller, and the caller releases it. Closes GH-18989.

1 parent fa960f7 commit 11ea995Copy full SHA for 11ea995

File tree

-1

lines changed

-1

lines changed

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,7 @@ PHP NEWS`
`13`	`13`	`- Curl:`
`14`	`14`	`. Fix memory leaks when returning refcounted value from curl callback.`
`15`	`15`	`(nielsdos)`
	`16`	`+ . Remove incorrect string release. (nielsdos)`
`16`	`17`
`17`	`18`	`- LDAP:`
`18`	`19`	`. Fixed GH-18902 ldap_exop/ldap_exop_sync assert triggered on empty`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1369,7 +1369,6 @@ static inline CURLcode add_simple_field(struct HttpPost **first, struct HttpPost`
`1369`	`1369`	`part = curl_mime_addpart(mime);`
`1370`	`1370`	`if (part == NULL) {`
`1371`	`1371`	`zend_tmp_string_release(tmp_postval);`
`1372`		`- zend_string_release_ex(string_key, 0);`
`1373`	`1372`	`return CURLE_OUT_OF_MEMORY;`
`1374`	`1373`	`}`
`1375`	`1374`	`if ((form_error = curl_mime_name(part, ZSTR_VAL(string_key))) != CURLE_OK`

Comments

(0)