Commit 7e54856

jrfnlgrogy

authored and

committed

GH Actions: harden the workflow against PHPCS ruleset errors

If there is a ruleset error, the `cs2pr` action doesn't receive an `xml` report and exits with a `0` error code, even though the PHPCS run failed (though not on CS errors, but on a ruleset error). This changes the GH Actions workflow to allow for that situation and still fail the build in that case.

1 parent f363c40 commit 7e54856Copy full SHA for 7e54856

File tree

1 file changed

-1

lines changed

.github/workflows
- test.yml

1 file changed

-1

lines changed

`‎.github/workflows/test.yml‎`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -34,10 +34,11 @@ jobs:`
`34`	`34`	`uses: ramsey/composer-install@v2`
`35`	`35`
`36`	`36`	`- name: Run code sniffer`
`37`		`- continue-on-error: true`
	`37`	`+ id: phpcs`
`38`	`38`	`run: vendor/bin/phpcs --report-full --report-checkstyle=./phpcs-report.xml`
`39`	`39`
`40`	`40`	`- name: Show PHPCS results in PR`
	`41`	`+ if: ${{ always() && steps.phpcs.outcome == 'failure' }}`
`41`	`42`	`run: cs2pr ./phpcs-report.xml`
`42`	`43`
`43`	`44`	`bundle:`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 7e54856

File tree

1 file changed

1 file changed

`‎.github/workflows/test.yml‎`

0 commit comments