Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Commit 2dfde55

Browse files
committed
GH Actions: run tests also on Windows OS
When running the tests locally, I realized that patch 146 did not actually work correctly on Windows. This commit adds test runs against Windows in CI on a limited number of PHP versions to prevent this kind of issue going unnoticed for future PRs. Note: the lowest PHP version I can get a running build on is PHP 5.5. This is related to SSL transport issues with Packagist with old Composer versions (which are needed for old PHP versions).
1 parent 5b45d93 commit 2dfde55

File tree

1 file changed

+15
-2
lines changed

1 file changed

+15
-2
lines changed

‎.github/workflows/test.yml‎

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,8 @@ jobs:
9191
path: ./parallel-lint.phar
9292

9393
test:
94-
name: Run tests on PHP ${{ matrix.php }}
95-
runs-on: ubuntu-latest
94+
name: Run tests on PHP ${{ matrix.php }} (${{ matrix.os }})
95+
runs-on: "${{ matrix.os }}"
9696
continue-on-error: ${{ matrix.php == '8.4' }}
9797
needs:
9898
- bundle
@@ -114,6 +114,19 @@ jobs:
114114
- '8.2'
115115
- '8.3'
116116
- '8.4'
117+
os:
118+
- 'ubuntu-latest'
119+
120+
include:
121+
# Also run the tests against Windows on a few PHP versions.
122+
- php: '5.5'
123+
os: 'windows-latest'
124+
- php: '7.0'
125+
os: 'windows-latest'
126+
- php: '8.0'
127+
os: 'windows-latest'
128+
- php: '8.3'
129+
os: 'windows-latest'
117130

118131
steps:
119132
- name: Checkout code

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /