Commit 9ce3f7c

committed

Use a property attributes instead of a key in headers

1 parent d748405 commit 9ce3f7cCopy full SHA for 9ce3f7c

File tree

+14

-25

lines changed

+14

-25

lines changed

Lines changed: 0 additions & 15 deletions

Original file line number	Diff line number	Diff line change
`@@ -62,21 +62,6 @@ $context->declareTopic($fooTopic);`
`62`	`62`	`$context->createProducer()->send($fooTopic, $message);`
`63`	`63`	```
`64`	`64`
`65`		`-You can send attributes using headers :`
`66`		`-`
`67`		-```php
`68`		`-<?php`
`69`		`-/** @var \Enqueue\Gps\GpsContext $context */`
`70`		`-`
`71`		`-$fooTopic = $context->createTopic('foo');`
`72`		`-$attributes = ['key1' => 'value1'];`
`73`		`-$message = $context->createMessage('Hello world!', [], ['attributes' => $attributes]);`
`74`		`-`
`75`		`-$context->declareTopic($fooTopic);`
`76`		`-`
`77`		`-$context->createProducer()->send($fooTopic, $message);`
`78`		-```
`79`		`-`
`80`	`65`	`## Consume message:`
`81`	`66`
`82`	`67`	`Before you can consume message you have to subscribe a queue to the topic.`

Lines changed: 12 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -24,6 +24,11 @@ class GpsMessage implements Message, \JsonSerializable`
`24`	`24`	`*/`
`25`	`25`	`private $headers;`
`26`	`26`
	`27`	`+ /**`
	`28`	`+ * @var array`
	`29`	`+ */`
	`30`	`+ private $attributes;`
	`31`	`+`
`27`	`32`	`/**`
`28`	`33`	`* @var bool`
`29`	`34`	`*/`
`@@ -34,18 +39,12 @@ class GpsMessage implements Message, \JsonSerializable`
`34`	`39`	`*/`
`35`	`40`	`private $nativeMessage;`
`36`	`41`
`37`		`- /**`
`38`		`- * @var array`
`39`		`- */`
`40`		`- private $attributes;`
`41`		`-`
`42`		`- public function __construct(string $body = '', array $properties = [], array $headers = [])`
	`42`	`+ public function __construct(string $body = '', array $properties = [], array $headers = [], array $attributes = [])`
`43`	`43`	`{`
`44`	`44`	`$this->body = $body;`
`45`	`45`	`$this->properties = $properties;`
`46`		`- $this->attributes = $headers['attributes'] ?? [];`
`47`		`- unset($headers['attributes']);`
`48`	`46`	`$this->headers = $headers;`
	`47`	`+ $this->attributes = $attributes;`
`49`	`48`
`50`	`49`	`$this->redelivered = false;`
`51`	`50`	`}`
`@@ -181,6 +180,11 @@ public function setNativeMessage(?GoogleMessage $message = null): void`
`181`	`180`	`$this->nativeMessage = $message;`
`182`	`181`	`}`
`183`	`182`
	`183`	`+ public function setAttributes(array $attributes): void`
	`184`	`+ {`
	`185`	`+ $this->attributes = $attributes;`
	`186`	`+ }`
	`187`	`+`
`184`	`188`	`public function getAttributes(): array`
`185`	`189`	`{`
`186`	`190`	`return $this->attributes;`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,7 @@ public function testThrowIfMalformedJsonGivenOnUnsterilizedFromJson()`
`73`	`73`
`74`	`74`	`public function testGetAttributes()`
`75`	`75`	`{`
`76`		`- $message = new GpsMessage('the body', [], ['attributes' => ['key1' => 'value1']]);`
	`76`	`+ $message = new GpsMessage('the body', [], [], ['key1' => 'value1']);`
`77`	`77`
`78`	`78`	`$attributes = $message->getAttributes();`
`79`	`79`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ public function testShouldSendMessage()`
`60`	`60`	`public function testShouldSendMessageWithAttributes()`
`61`	`61`	`{`
`62`	`62`	`$topic = new GpsTopic('topic-name');`
`63`		`- $message = new GpsMessage('', [], ['attributes' => ['key1' => 'value1']]);`
	`63`	`+ $message = new GpsMessage('', [], [], ['key1' => 'value1']);`
`64`	`64`
`65`	`65`	`$gtopic = $this->createGTopicMock();`
`66`	`66`	`$gtopic`

Comments

(0)