Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Align with java-diff-utils 4.12 #101

Closed
lppedd started this conversation in General
Discussion options

Hey! Thanks for this KMP library.

I'm planning to adopt it to batch saving editor changes. That is, at save time - after diffing the two states - I'm going to collect all inserts, all deletions, and all edits, and perform the necessary operations to persist those changes. Sounds crazy but there is always a reason.

To do this I'd like to use the Myers algorithm in linear space, which this library is currently lacking.
I think the best path would be to have you adopt the upstream changes, since you know where you left the project.

I'll then experiment with adopting it, I'll evaluate performance, and come back with PRs if necessary, like what I did for antlr-kotlin (although in that case I did also port the upstream changes).

Or would you prefer I do everything? Let me know if you don't have the time.

You must be logged in to vote

Replies: 2 comments

Comment options

Hey! TBH I don't have that much time at the moment. I'll be happy to review PRs if you'd like to submit any, though.

You must be logged in to vote
0 replies
Comment options

We can close as it's been done.

You must be logged in to vote
0 replies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants

AltStyle によって変換されたページ (->オリジナル) /