Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

TST: Replace ensure_clean utility function with the temp_file pytest fixture #62435

Open
Assignees
Labels
Testingpandas testing functions or related to the test suite good first issue
@mroeschke

Description

The pandas test suite uses an ensure_clean utility function to create a temporary file for testing

def ensure_clean(filename=None) -> Generator[Any]:

This utility should be largely redundant with the temp_file pytest fixture

def temp_file(tmp_path):

Since there are about ~180 occurrences of ensure_clean in the code base, this issue should be completed in multiple PRs that replaces ensure_clean with temp_file in a particular file. Therefore, this issue can be worked on by multiple contributors.

For those interested in working on this issue:

  1. Comment below on which file in pandas/tests you'll be working on.
  2. Submit a PR that replace ensure_clean with temp_file which still passes the tests.

When submitting a PR for a fix:

  • If a test doesn't appear to explicitly need to test a str file argument, please change the test to use temp_file directly (i.e. avoid doing str(temp_file) if not needed)
  • If a test requires a specific file name or extension (e.g. .xls), please construct an argument using the pytest tmp_path fixture instead (e.g. path = tmp_path / "tmp.xls")

Once all the uses of ensure_clean are replaced, a separate PR to remove ensure_clean would be welcome.

Metadata

Metadata

Labels

Testingpandas testing functions or related to the test suite good first issue

Type

No type

Projects

No projects

Milestone

No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      AltStyle によって変換されたページ (->オリジナル) /