Commit 8d68063

committed

BUG: Fix Index.get_level_values() with boolean, NaN, NA, NaT names

1 parent 10a5305 commit 8d68063Copy full SHA for 8d68063

File tree

2 files changed

+17

-6

lines changed

doc/source/whatsnew
- v3.0.0.rst
pandas/core/indexes
- base.py

2 files changed

+17

-6

lines changed

`‎doc/source/whatsnew/v3.0.0.rst‎`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1142,6 +1142,7 @@ Other`
`1142`	`1142`	- Bug in :meth:`DataFrame.transform` that was returning the wrong order unless the index was monotonically increasing. (:issue:`57069`)
`1143`	`1143`	- Bug in :meth:`DataFrame.where` where using a non-bool type array in the function would return a ``ValueError`` instead of a ``TypeError`` (:issue:`56330`)
`1144`	`1144`	- Bug in :meth:`Index.sort_values` when passing a key function that turns values into tuples, e.g. ``key=natsort.natsort_key``, would raise ``TypeError`` (:issue:`56081`)
	`1145`	+- Bug in :meth:`Index.get_level_values` incorrectly handling boolean, ``np.nan``, ``pd.NA``, and ``pd.NaT`` level names (:issue:`TBD`)
`1145`	`1146`	- Bug in :meth:`MultiIndex.fillna` error message was referring to ``isna`` instead of ``fillna`` (:issue:`60974`)
`1146`	`1147`	- Bug in :meth:`Series.describe` where median percentile was always included when the ``percentiles`` argument was passed (:issue:`60550`).
`1147`	`1148`	- Bug in :meth:`Series.diff` allowing non-integer values for the ``periods`` argument. (:issue:`56607`)

`‎pandas/core/indexes/base.py‎`

Lines changed: 16 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -38,6 +38,7 @@`
`38`	`38`	`is_datetime_array,`
`39`	`39`	`no_default,`
`40`	`40`	`)`
	`41`	`+from pandas._libs.missing import is_matching_na`
`41`	`42`	`from pandas._libs.tslibs import (`
`42`	`43`	`OutOfBoundsDatetime,`
`43`	`44`	`Timestamp,`
`@@ -2087,7 +2088,9 @@ def _validate_index_level(self, level) -> None:`
`2087`	`2088`	`verification must be done like in MultiIndex.`
`2088`	`2089`
`2089`	`2090`	`"""`
`2090`		`- if isinstance(level, int):`
	`2091`	`+ if lib.is_integer(level):`
	`2092`	`+ if isinstance(self.name, int) and self.name == level:`
	`2093`	`+ return`
`2091`	`2094`	`if level < 0 and level != -1:`
`2092`	`2095`	`raise IndexError(`
`2093`	`2096`	`"Too many levels: Index has only 1 level, "`
`@@ -2097,10 +2100,17 @@ def _validate_index_level(self, level) -> None:`
`2097`	`2100`	`raise IndexError(`
`2098`	`2101`	`f"Too many levels: Index has only 1 level, not {level + 1}"`
`2099`	`2102`	`)`
	`2103`	`+ mismatch_error_msg = (`
	`2104`	`+ f"Requested level ({level}) does not match index name ({self.name})"`
	`2105`	`+ )`
	`2106`	`+ if isna(level) and isna(self.name):`
	`2107`	`+ if not is_matching_na(level, self.name):`
	`2108`	`+ raise KeyError(mismatch_error_msg)`
	`2109`	`+ return`
	`2110`	`+ elif isna(level) or isna(self.name):`
	`2111`	`+ raise KeyError(mismatch_error_msg)`
`2100`	`2112`	`elif level != self.name:`
`2101`		`- raise KeyError(`
`2102`		`- f"Requested level ({level}) does not match index name ({self.name})"`
`2103`		`- )`
	`2113`	`+ raise KeyError(mismatch_error_msg)`
`2104`	`2114`
`2105`	`2115`	`def _get_level_number(self, level) -> int:`
`2106`	`2116`	`self._validate_index_level(level)`
`@@ -3069,7 +3079,7 @@ def union(self, other, sort: bool \| None = None):`
`3069`	`3079`	`"""`
`3070`	`3080`	`self._validate_sort_keyword(sort)`
`3071`	`3081`	`self._assert_can_do_setop(other)`
`3072`		`- other, result_name = self._convert_can_do_setop(other)`
	`3082`	`+ other, _result_name = self._convert_can_do_setop(other)`
`3073`	`3083`
`3074`	`3084`	`if self.dtype != other.dtype:`
`3075`	`3085`	`if (`
`@@ -6079,7 +6089,7 @@ def _get_indexer_strict(self, key, axis_name: str_t) -> tuple[Index, np.ndarray]`
`6079`	`6089`	`indexer = self.get_indexer_for(keyarr)`
`6080`	`6090`	`keyarr = self.reindex(keyarr)[0]`
`6081`	`6091`	`else:`
`6082`		`- keyarr, indexer, new_indexer = self._reindex_non_unique(keyarr)`
	`6092`	`+ keyarr, indexer, _new_indexer = self._reindex_non_unique(keyarr)`
`6083`	`6093`
`6084`	`6094`	`self._raise_if_missing(keyarr, indexer, axis_name)`
`6085`	`6095`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit 8d68063

File tree

2 files changed

2 files changed

`‎doc/source/whatsnew/v3.0.0.rst‎`

`‎pandas/core/indexes/base.py‎`

0 commit comments