Commit 4e474f4

authored

BUG: divmod with bool dtype failing to raise (#62247)

1 parent 0ee266c commit 4e474f4Copy full SHA for 4e474f4

File tree

+31

-0

lines changed

+31

-0

lines changed

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1120,6 +1120,7 @@ Other`
`1120`	`1120`	- Bug in ``Series.list`` methods not preserving the original :class:`Index`. (:issue:`58425`)
`1121`	`1121`	- Bug in ``Series.list`` methods not preserving the original name. (:issue:`60522`)
`1122`	`1122`	- Bug in ``Series.replace`` when the Series was created from an :class:`Index` and Copy-On-Write is enabled (:issue:`61622`)
	`1123`	+- Bug in ``divmod`` and ``rdivmod`` with :class:`DataFrame`, :class:`Series`, and :class:`Index` with ``bool`` dtypes failing to raise, which was inconsistent with ``__floordiv__`` behavior (:issue:`46043`)
`1123`	`1124`	- Bug in printing a :class:`DataFrame` with a :class:`DataFrame` stored in :attr:`DataFrame.attrs` raised a ``ValueError`` (:issue:`60455`)
`1124`	`1125`	- Bug in printing a :class:`Series` with a :class:`DataFrame` stored in :attr:`Series.attrs` raised a ``ValueError`` (:issue:`60568`)
`1125`	`1126`	- Fixed bug where the :class:`DataFrame` constructor misclassified array-like objects with a ``.name`` attribute as :class:`Series` or :class:`Index` (:issue:`61443`)

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -585,6 +585,8 @@ def maybe_prepare_scalar_for_op(obj, shape: Shape):`
`585`	`585`	`roperator.rfloordiv,`
`586`	`586`	`operator.pow,`
`587`	`587`	`roperator.rpow,`
	`588`	`+ divmod,`
	`589`	`+ roperator.rdivmod,`
`588`	`590`	`}`
`589`	`591`
`590`	`592`

Lines changed: 28 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,28 @@`
	`1`	`+import pytest`
	`2`	`+`
	`3`	`+from pandas import (`
	`4`	`+ DataFrame,`
	`5`	`+ Series,`
	`6`	`+)`
	`7`	`+import pandas._testing as tm`
	`8`	`+`
	`9`	`+`
	`10`	`+def test_divmod_bool_raises(box_with_array):`
	`11`	`+ # GH#46043 // raises, so divmod should too`
	`12`	`+ ser = Series([True, False])`
	`13`	`+ obj = tm.box_expected(ser, box_with_array)`
	`14`	`+`
	`15`	`+ msg = "operator 'floordiv' not implemented for bool dtypes"`
	`16`	`+ with pytest.raises(NotImplementedError, match=msg):`
	`17`	`+ obj // obj`
	`18`	`+`
	`19`	`+ if box_with_array is DataFrame:`
	`20`	`+ msg = "operator 'floordiv' not implemented for bool dtypes"`
	`21`	`+ else:`
	`22`	`+ msg = "operator 'divmod' not implemented for bool dtypes"`
	`23`	`+ with pytest.raises(NotImplementedError, match=msg):`
	`24`	`+ divmod(obj, obj)`
	`25`	`+`
	`26`	`+ # go through __rdivmod__`
	`27`	`+ with pytest.raises(NotImplementedError, match=msg):`
	`28`	`+ divmod(True, obj)`

Comments

(0)