Commit bd6a02d

WGH-zimmerle

authored and

committed

Fix test issue-1831.json on LMDB

When LMDB is enabled, ModSecurity stores its persistent variables in "./modsec-shared-collections" file. Since this file wasn't cleared between tests, tests behaved differently on "in-memory per-process" and LMDB backend. This test never worked in LMDB configuration. It hasn't been discovered until now because Travis CI didn't test LMDB configuration when test was introduced.

1 parent 37cf60b commit bd6a02dCopy full SHA for bd6a02d

File tree

1 file changed

-0

lines changed

test/regression
- regression.cc

1 file changed

-0

lines changed

`‎test/regression/regression.cc‎`

Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -15,6 +15,8 @@`
`15`	`15`
`16`	`16`	`#include <string.h>`
`17`	`17`
	`18`	`+#include <unistd.h>`
	`19`	`+`
`18`	`20`	`#include <ctime>`
`19`	`21`	`#include <iostream>`
`20`	`22`	`#include <string>`
`@@ -136,6 +138,12 @@ void perform_unit_test(ModSecurityTest<RegressionTest> *test,`
`136`	`138`	`continue;`
`137`	`139`	`}`
`138`	`140`
	`141`	`+#ifdef WITH_LMDB`
	`142`	`+ // some tests (e.g. issue-1831.json) don't like it when data persists between runs`
	`143`	`+ unlink("./modsec-shared-collections");`
	`144`	`+ unlink("./modsec-shared-collections-lock");`
	`145`	`+#endif`
	`146`	`+`
`139`	`147`	`modsec = new modsecurity::ModSecurity();`
`140`	`148`	`modsec->setConnectorInformation("ModSecurity-regression v0.0.1-alpha" \`
`141`	`149`	`" (ModSecurity regression test utility)");`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit bd6a02d

File tree

1 file changed

1 file changed

`‎test/regression/regression.cc‎`

0 commit comments