Commit 9fea1ca

committed

Change cast type (fix SonarCloud issues)

1 parent 47bc24a commit 9fea1caCopy full SHA for 9fea1ca

File tree

-2

lines changed

-2

lines changed

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -226,9 +226,12 @@ bool Rbl::evaluate(Transaction t, RuleWithActions rule,`
`226`	`226`	`return false;`
`227`	`227`	`}`
`228`	`228`
	`229`	`+ // NOSONAR`
	`230`	`+ // SonarCloud suggested to use the init-statement to declare "addr" inside the if statement.`
	`231`	`+ // I think that's not good here, because we need that in the else block`
`229`	`232`	`struct sockaddr *addr = info->ai_addr;`
`230`	`233`	`if (addr->sa_family == AF_INET) { // only IPv4 address is allowed`
`231`		`- struct sockaddr_in sin = reinterpret_cast<struct sockaddr_in >(addr);`
	`234`	`+ struct sockaddr_in sin = (struct sockaddr_in ) addr; // cppcheck-suppress[dangerousTypeCast]`
`232`	`235`	`furtherInfo(sin, ipStr, t, m_provider);`
`233`	`236`	`}`
`234`	`237`	`else {`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ void XML::evaluate(Transaction *t,`
`91`	`91`	`} else {`
`92`	`92`	`std::vector<actions::Action *> acts = rule->getActionsByName("xmlns", t);`
`93`	`93`	`for (auto &x : acts) {`
`94`		`- actions::XmlNS z = reinterpret_cast<actions::XmlNS >(x);`
	`94`	`+ actions::XmlNS z = static_cast<actions::XmlNS >(x);`
`95`	`95`	`if (xmlXPathRegisterNs(xpathCtx, reinterpret_cast<const xmlChar*>(z->m_scope.c_str()),`
`96`	`96`	`reinterpret_cast<const xmlChar*>(z->m_href.c_str())) != 0) {`
`97`	`97`	`ms_dbg_a(t, 1, "Failed to register XML namespace href \"" + \`

Comments

(0)