Commit 31fb939

committed

Replaced string parameters with string_view in AuditLog

1 parent 2ee45de commit 31fb939Copy full SHA for 31fb939

File tree

2 files changed

+16

-16

lines changed

headers/modsecurity
- audit_log.h
src/audit_log
- audit_log.cc

2 files changed

+16

-16

lines changed

`‎headers/modsecurity/audit_log.h‎`

Lines changed: 8 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -153,18 +153,18 @@ class AuditLog {`
`153`	`153`	`bool setStorageDirMode(int permission);`
`154`	`154`	`bool setFileMode(int permission);`
`155`	`155`	`bool setStatus(AuditLogStatus new_status);`
`156`		`- bool setRelevantStatus(conststd::basic_string<char>& new_relevant_status);`
`157`		`- bool setFilePath1(conststd::basic_string<char>& path);`
`158`		`- bool setFilePath2(conststd::basic_string<char>& path);`
`159`		`- bool setStorageDir(conststd::basic_string<char>& path);`
`160`		`- bool setHeader(conststd::basic_string<char>& header);`
	`156`	`+ bool setRelevantStatus(std::string_view new_relevant_status);`
	`157`	`+ bool setFilePath1(std::string_view path);`
	`158`	`+ bool setFilePath2(std::string_view path);`
	`159`	`+ bool setStorageDir(std::string_view path);`
	`160`	`+ bool setHeader(std::string_view header);`
`161`	`161`	`bool setFormat(AuditLogFormat fmt);`
`162`	`162`
`163`	`163`	`int getDirectoryPermission() const;`
`164`	`164`	`int getFilePermission() const;`
`165`	`165`	`int getParts() const;`
`166`	`166`
`167`		`- bool setParts(conststd::basic_string<char>& new_parts);`
	`167`	`+ bool setParts(std::string_view new_parts);`
`168`	`168`	`bool setType(AuditLogType audit_type);`
`169`	`169`
`170`	`170`	`bool init(std::string *error);`
`@@ -174,8 +174,8 @@ class AuditLog {`
`174`	`174`	`bool saveIfRelevant(Transaction *transaction, int parts);`
`175`	`175`	`bool isRelevant(int status);`
`176`	`176`
`177`		`- static int addParts(int parts, conststd::string& new_parts);`
`178`		`- static int removeParts(int parts, conststd::string& new_parts);`
	`177`	`+ static int addParts(int parts, std::string_view new_parts);`
	`178`	`+ static int removeParts(int parts, std::string_view new_parts);`
`179`	`179`
`180`	`180`	`void setCtlAuditEngineActive() {`
`181`	`181`	`m_ctlAuditEngineActive = true;`

`‎src/audit_log/audit_log.cc‎`

Lines changed: 8 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -109,31 +109,31 @@ bool AuditLog::setStatus(AuditLogStatus status) {`
`109`	`109`	`}`
`110`	`110`
`111`	`111`
`112`		`-bool AuditLog::setRelevantStatus(conststd::basic_string<char>& status) {`
	`112`	`+bool AuditLog::setRelevantStatus(std::string_view status) {`
`113`	`113`	`this->m_relevant = std::string(status);`
`114`	`114`	`return true;`
`115`	`115`	`}`
`116`	`116`
`117`	`117`
`118`		`-bool AuditLog::setStorageDir(conststd::basic_string<char>& path) {`
	`118`	`+bool AuditLog::setStorageDir(std::string_view path) {`
`119`	`119`	`this->m_storage_dir = path;`
`120`	`120`	`return true;`
`121`	`121`	`}`
`122`	`122`
`123`	`123`
`124`		`-bool AuditLog::setFilePath1(conststd::basic_string<char>& path) {`
	`124`	`+bool AuditLog::setFilePath1(std::string_view path) {`
`125`	`125`	`this->m_path1 = path;`
`126`	`126`	`return true;`
`127`	`127`	`}`
`128`	`128`
`129`	`129`
`130`		`-bool AuditLog::setFilePath2(conststd::basic_string<char>& path) {`
	`130`	`+bool AuditLog::setFilePath2(std::string_view path) {`
`131`	`131`	`this->m_path2 = path;`
`132`	`132`	`return true;`
`133`	`133`	`}`
`134`	`134`
`135`	`135`
`136`		`-bool AuditLog::setHeader(conststd::basic_string<char>& header) {`
	`136`	`+bool AuditLog::setHeader(std::string_view header) {`
`137`	`137`	`this->m_header = header;`
`138`	`138`	`return true;`
`139`	`139`	`}`
`@@ -144,7 +144,7 @@ bool AuditLog::setFormat(AuditLogFormat fmt) {`
`144`	`144`	`return true;`
`145`	`145`	`}`
`146`	`146`
`147`		`-int AuditLog::addParts(int parts, conststd::string& new_parts) {`
	`147`	`+int AuditLog::addParts(int parts, std::string_view new_parts) {`
`148`	`148`	`PARTS_CONSTAINS('A', AAuditLogPart)`
`149`	`149`	`PARTS_CONSTAINS('B', BAuditLogPart)`
`150`	`150`	`PARTS_CONSTAINS('C', CAuditLogPart)`
`@@ -162,7 +162,7 @@ int AuditLog::addParts(int parts, const std::string& new_parts) {`
`162`	`162`	`}`
`163`	`163`
`164`	`164`
`165`		`-int AuditLog::removeParts(int parts, conststd::string& new_parts) {`
	`165`	`+int AuditLog::removeParts(int parts, std::string_view new_parts) {`
`166`	`166`	`PARTS_CONSTAINS_REM('A', AAuditLogPart)`
`167`	`167`	`PARTS_CONSTAINS_REM('B', BAuditLogPart)`
`168`	`168`	`PARTS_CONSTAINS_REM('C', CAuditLogPart)`
`@@ -180,7 +180,7 @@ int AuditLog::removeParts(int parts, const std::string& new_parts) {`
`180`	`180`	`}`
`181`	`181`
`182`	`182`
`183`		`-bool AuditLog::setParts(conststd::basic_string<char>& new_parts) {`
	`183`	`+bool AuditLog::setParts(std::string_view new_parts) {`
`184`	`184`	`int parts = 0;`
`185`	`185`
`186`	`186`	`PARTS_CONSTAINS('A', AAuditLogPart)`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 31fb939

File tree

2 files changed

2 files changed

`‎headers/modsecurity/audit_log.h‎`

`‎src/audit_log/audit_log.cc‎`

0 commit comments