Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

support SMP in appropriate types #2514

Open
Labels
lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.
@sascha-tanke-bdr

Description

Some type definitions are not supporting strategic merge patches (SMP). This makes it hard, to patch resources from different sides.

An example:

An ArgoCD rolles out a patch to .spec.servers in dnses.operator.openshift.io, as it defines some forwards for special dns setups. On top Submariner Operator wants to patch its lighthouse forward into the same resource. That isn't working, as SMP is not support via a mergeKey (https://kubernetes.io/docs/tasks/manage-kubernetes-objects/declarative-config/#merge-individual-elements-of-a-list-of-complex-elements, https://github.com/kubernetes/apimachinery/blob/268a6d0fb19c92c9665e8f5cd85b564557038dc1/pkg/util/strategicpatch/patch.go#L321). This could be made possible by adding patchMergeKey to:

Servers []Server `json:"servers,omitempty"`

Would be nice to add this to all appropriate types.

Metadata

Metadata

Assignees

No one assigned

    Labels

    lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

        AltStyle によって変換されたページ (->オリジナル) /