Commit 05b74a5

authored

ci: remove --timings flag for Next.js repo e2e tests (#2912)

This doesn't seem to provide any value for us. It just adds some test run time and instability to our suite, since this ends up attempting to read a `test-timings.json` file from disk (fails every time) and then makes a request to fetch timings data from a private Vercel endpoint, which sometimes fails with a 403 for some reason.

1 parent 65d60ca commit 05b74a5Copy full SHA for 05b74a5

File tree

1 file changed

-1

lines changed

.github/workflows
- test-e2e.yml

1 file changed

-1

lines changed

`‎.github/workflows/test-e2e.yml`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -198,7 +198,7 @@ jobs:`
`198`	`198`	`NODE_ENV: production`
`199`	`199`	`NEXT_EXTERNAL_TESTS_FILTERS: ${{ steps.test-filters.outputs.filters }}`
`200`	`200`	`NEXT_TEST_SKIP_RETRY_MANIFEST: ${{ steps.test-filters.outputs.skip-retry }}`
`201`		`- run: node run-tests.js -g ${{ matrix.group }}/${{ needs.setup.outputs.total }} -c ${TEST_CONCURRENCY} --type e2e --timings`
	`201`	`+ run: node run-tests.js -g ${{ matrix.group }}/${{ needs.setup.outputs.total }} -c ${TEST_CONCURRENCY} --type e2e`
`202`	`202`	`working-directory: ${{ env.next-path }}`
`203`	`203`
`204`	`204`	`- name: Upload Test Results`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 05b74a5

File tree

1 file changed

1 file changed

`‎.github/workflows/test-e2e.yml`

0 commit comments