Skip to content

Navigation Menu

Sign in
Sign up

[MNT] Add Missing Assertions to Run Function Tests #1646

Open
Labels
Good First IssueIssues suitable for people new to contributing to openml-python! module:RunOpenML concept testing

Description

Several tests in test_run_functions.py have TODO comments indicating missing assertions (e.g., lines 170, 287, 291, 341, 514, 555). These include checks for holdout tasks, parameter presence, and runtime values, which would improve test reliability.

Steps:

  1. Review each TODO comment and the surrounding test code to understand what's being tested.
  2. Add appropriate assertions, such as:
    • assert task.task_type == "holdout" for holdout task checks.
    • assert "runtime" in run.attributes for runtime presence.
    • assert len(run.parameters) > 0 for parameter checks.
  3. Run the tests to ensure they pass and cover the intended behavior.
  4. If needed, mock or set up test data to make assertions deterministic.

Tests will be more comprehensive, catching regressions in run handling and parameter validation.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Good First IssueIssues suitable for people new to contributing to openml-python! module:RunOpenML concept testing

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      AltStyle によって変換されたページ (->オリジナル) /