Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Make required fields required #100

Open
Labels
breaking-changeWill result in a breaking change to the API

Description

This includes:

  • In WriteAuthorizationModelRequest, schema_version should be required
  • In ReadAuthorizationModelRequest, id should be required
  • In TupleKey all are required
  • All responses

These currently cause a lot of DX problems in the SDKs, as the generated types show that the fields are optional.

E.g. In the typescript SDK, users have to check for nullability on responses even if we know it will never be null, and they mistakenly think that some fields are optional in requests even when they are.

In the Go SDK, we have to make the fields accept pointer instead of values because of this when it is unnecessary

Metadata

Metadata

Assignees

No one assigned

    Labels

    breaking-changeWill result in a breaking change to the API

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

        AltStyle によって変換されたページ (->オリジナル) /