Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Commit f82426c

Browse files
removed unused error handlers
1 parent 55f12d2 commit f82426c

File tree

6 files changed

+0
-168
lines changed

6 files changed

+0
-168
lines changed

‎src/app/components/ErrorHandling/ErrorHandler.tsx

Lines changed: 0 additions & 21 deletions
This file was deleted.

‎src/app/components/ErrorHandling/ErrorMsg.tsx

Lines changed: 0 additions & 92 deletions
This file was deleted.

‎src/app/components/ErrorHandling/Loader.tsx

Lines changed: 0 additions & 32 deletions
This file was deleted.

‎src/app/slices/mainSlice.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -128,14 +128,6 @@ export const mainSlice = createSlice({
128128
state.port = action.payload;
129129
},
130130

131-
// JR: REFACTOR: 12.20.23 this code has if statement to catch diff shapes of payload ('number' vs 'object'). This should not be the case, the payload should always come in as expected.
132-
// consider creating a custom typescript type for the action that setTab receives.
133-
134-
//JR: DOCS: 12.20.23 This code will update the currentTab being tracked in the Redux state. It depends, however, on the 'mode', which is a label for the "Locked" button status.
135-
// The naming is unfortunate because the backend also has a mode variable that does a completely different thing (related to time travel navigation), which creates confusion. Consider renaming this to 'locked' or somesuch.
136-
// Mode is an object that expects to contain a single key, paused, with a boolean value.
137-
// If true: Reactime is 'Locked', and navigating to another tab will not update the Redux state and trigger Reactime to take any actions.
138-
// If false: Reactime is 'Unlocked', and navigating to another tab will update the Redux state's currentTab, which will trigger Reactime to try to run on that new tab.
139131
setTab: (state, action) => {
140132
const { tabs, currentTab } = state;
141133
const { mode } = tabs[currentTab] || {};

‎src/app/styles/layout/_errorContainer.scss

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -42,20 +42,6 @@
4242
margin-bottom: 1rem;
4343
}
4444

45-
.loaderChecks {
46-
margin: 1.5rem 0;
47-
}
48-
49-
.loaderChecks p {
50-
color: var(--text-secondary);
51-
font-size: 0.875rem;
52-
line-height: 1.5;
53-
font-weight: 500;
54-
display: flex;
55-
align-items: center;
56-
gap: 0.5rem;
57-
}
58-
5945
.error-note {
6046
text-align: center;
6147
color: var(--text-tertiary);

‎src/extension/background.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -662,7 +662,6 @@ chrome.runtime.onMessage.addListener(async (request, sender, sendResponse) => {
662662
htmlBody.appendChild(script);
663663
};
664664

665-
//if (tab.url?.startsWith("chrome://")) return undefined;
666665
chrome.scripting.executeScript({
667666
target: { tabId },
668667
func: injectScript,

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /