Commit db2ec95

committed

Set typed = true as default for properties - Close #8

1 parent a532ff6 commit db2ec95Copy full SHA for db2ec95

File tree

8 files changed

+11

-11

lines changed

src
- Builder
- Code
  - MethodGenerator.php
  - PropertyGenerator.php
- NodeVisitor
  - Property.php
tests/Code
- PropertyGeneratorTest.php

8 files changed

+11

-11

lines changed

`‎src/Builder/ClassBuilder.php`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ final class ClassBuilder implements File`
`35`	`35`	`private bool $strict = false;`
`36`	`36`
`37`	`37`	`/** @var bool */`
`38`		`- private bool $typed = false;`
	`38`	`+ private bool $typed = true;`
`39`	`39`
`40`	`40`	`/** @var bool */`
`41`	`41`	`private bool $final = false;`

`‎src/Builder/ClassMethodBuilder.php`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ final class ClassMethodBuilder`
`44`	`44`	`private int $visibility;`
`45`	`45`
`46`	`46`	`/** @var bool */`
`47`		`- private bool $typed = false;`
	`47`	`+ private bool $typed = true;`
`48`	`48`
`49`	`49`	`/**`
`50`	`50`	`* @var string\|null`

`‎src/Builder/ClassPropertyBuilder.php`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ final class ClassPropertyBuilder`
`36`	`36`	`private int $visibility;`
`37`	`37`
`38`	`38`	`/** @var bool */`
`39`		`- private bool $typed = false;`
	`39`	`+ private bool $typed = true;`
`40`	`40`
`41`	`41`	`/**`
`42`	`42`	`* @var string\|null`

`‎src/Builder/InterfaceBuilder.php`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ final class InterfaceBuilder implements File`
`33`	`33`	`private bool $strict = false;`
`34`	`34`
`35`	`35`	`/** @var bool */`
`36`		`- private bool $typed = false;`
	`36`	`+ private bool $typed = true;`
`37`	`37`
`38`	`38`	`/** @var string[] */`
`39`	`39`	`private array $extends = [];`

`‎src/Code/MethodGenerator.php`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ final class MethodGenerator extends AbstractMemberGenerator`
`45`	`45`	`/**`
`46`	`46`	`* @var bool`
`47`	`47`	`*/`
`48`		`- private bool $typed = false;`
	`48`	`+ private bool $typed = true;`
`49`	`49`
`50`	`50`	`/**`
`51`	`51`	`* @var string\|null`

`‎src/Code/PropertyGenerator.php`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ public function __construct(`
`60`	`60`	`string $name = null,`
`61`	`61`	`string $type = null,`
`62`	`62`	`$defaultValue = null,`
`63`		`- bool $typed = false,`
	`63`	`+ bool $typed = true,`
`64`	`64`	`int $flags = self::FLAG_PRIVATE`
`65`	`65`	`) {`
`66`	`66`	`if (null !== $name) {`

`‎src/NodeVisitor/Property.php`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ public static function forClassProperty(`
`33`	`33`	`string $name = null,`
`34`	`34`	`string $type = null,`
`35`	`35`	`$defaultValue = null,`
`36`		`- bool $typed = false,`
	`36`	`+ bool $typed = true,`
`37`	`37`	`int $flags = PropertyGenerator::FLAG_PRIVATE`
`38`	`38`	`): self {`
`39`	`39`	`return new self(`

`‎tests/Code/PropertyGeneratorTest.php`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ public function setUp(): void`
`40`	`40`	`*/`
`41`	`41`	`public function it_generates_property_with_doc_block(): void`
`42`	`42`	`{`
`43`		`- $property = new PropertyGenerator('sourceFolder', 'string');`
	`43`	`+ $property = new PropertyGenerator('sourceFolder', 'string', null, false);`
`44`	`44`	`$property->setDocBlockComment('source folder');`
`45`	`45`
`46`	`46`	`$expectedOutput = <<<'EOF'`
`@@ -62,7 +62,7 @@ public function it_generates_property_with_doc_block(): void`
`62`	`62`	`*/`
`63`	`63`	`public function it_generates_property_with_overridden_doc_block(): void`
`64`	`64`	`{`
`65`		`- $property = new PropertyGenerator('sourceFolder', 'string');`
	`65`	`+ $property = new PropertyGenerator('sourceFolder', 'string', null, false);`
`66`	`66`	`$property->setDocBlockComment('source folder');`
`67`	`67`	`$property->overrideDocBlock(new DocBlock('Awesome'));`
`68`	`68`
`@@ -92,7 +92,7 @@ public function it_generates_property_with_array_type_doc_block(): void`
`92`	`92`	`/**`
`93`	`93`	`* @var array<string, \stdClass>`
`94`	`94`	`*/`
`95`		`-private $items;`
	`95`	`+private array $items;`
`96`	`96`	`EOF;`
`97`	`97`
`98`	`98`	`$this->assertSame($expectedOutput, $this->printer->prettyPrintFile([$property->generate()]));`
`@@ -130,7 +130,7 @@ public function it_generates_property_with_long_doc_block(): void`
`130`	`130`	`*`
`131`	`131`	`* @var string`
`132`	`132`	`*/`
`133`		`-private $sourceFolder;`
	`133`	`+private string $sourceFolder;`
`134`	`134`	`EOF;`
`135`	`135`
`136`	`136`	`$this->assertSame($expectedOutput, $this->printer->prettyPrintFile([$property->generate()]));`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit db2ec95

File tree

8 files changed

8 files changed

`‎src/Builder/ClassBuilder.php`

`‎src/Builder/ClassMethodBuilder.php`

`‎src/Builder/ClassPropertyBuilder.php`

`‎src/Builder/InterfaceBuilder.php`

`‎src/Code/MethodGenerator.php`

`‎src/Code/PropertyGenerator.php`

`‎src/NodeVisitor/Property.php`

`‎tests/Code/PropertyGeneratorTest.php`

0 commit comments