Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[CRIT] Vao/Buffer state can be corrupted #141

Open
@eXponenta

Description

if (this.gl.renderer.currentGeometry !== `${this.id}_${program.attributeOrder}`) {

When we bind VAO or unbind it we should and change renderer.currentGeometry, this is IMPORTANT because some code call only bindVertexArray.

See:
https://github.com/oframe/ogl/blob/master/src/extras/GLTFLoader.js#L92

Because we have a VAO Abstraction, why we can't store it in renderer.currentGeometry inside renderer?
This is more strictly that store string literal.

Then need move currentGeometry to state.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

        AltStyle によって変換されたページ (->オリジナル) /