Skip to content

Navigation Menu

Sign in
Sign up

proposal: add MockModuleOptions.preserveOthers #32

Open

Description

This would simplify mocking only a subset of a module's exports. A common use-case for this is a method that will do something undesirable in a test environment, like start a server.

Currently, it's possible with some non-obvious gymnastics:

describe('Example', () => {
 let example;
 before(async () => {
 example = await import('./example.mjs');
 const theMock = mock.module('./example.mjs', {
 namedExports: {
 ...example,
 theOneThingToMock: mock.fn(),
 },
 });
 // Must do this again!
 example = await import('./example.mjs');
 });
});

Instead, with preserveOthers, it's more straightforward:

describe('Example', () => {
 let example;
 before(async () => {
 const theMock = mock.module('./example.mjs', {
 namedExports: {
 theOneThingToMock: mock.fn(),
 },
 preserveOthers: true,
 });
 example = await import('./example.mjs');
 });
});

There is some hidden complexity in the implementation though: When a module is loaded, it’s immediately added to the module cache (which is controlled by V8—node can’t manipulate it).

So we’ll need to do some trickery like initially load the module with a query param appended to the specifier (which may already have a query param of its own 🤪), grab the exports and cache them for as long as the module is in scope: A module can be mocked multiple times, potentially with different replacements. We’ll need to diff replacements and original.


This would also facilitate supporting a feature like Jest's requireActual: theMock.getOriginal.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

Projects

Milestone

No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    AltStyle によって変換されたページ (->オリジナル) /