Commit 8a109e7

KamalAmanmattphillips

authored and

committed

Fixes bug with difference dates in the same second returning true (mattphillips#12)

1 parent 49e6acf commit 8a109e7Copy full SHA for 8a109e7

File tree

-2

lines changed

-2

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@ const diff = (lhs, rhs) => {`
`13`	`13`	`}, {});`
`14`	`14`
`15`	`15`	`if (isDate(l) \|\| isDate(r)) {`
`16`		`- if (l.toString() == r.toString()) return {};`
	`16`	`+ if (l.valueOf() == r.valueOf()) return {};`
`17`	`17`	`return r;`
`18`	`18`	`}`
`19`	`19`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -35,6 +35,7 @@ describe('.diff', () => {`
`35`	`35`	`[100, () => ({})],`
`36`	`36`	`[() => ({}), 100],`
`37`	`37`	`[new Date('2017年01月01日'), new Date('2017年01月02日')],`
	`38`	`+ [new Date('2017年01月01日T00:00:00.636Z'), new Date('2017年01月01日T00:00:00.637Z')],`
`38`	`39`	`]).test('returns right hand side value when different to left hand side value (%s, %s)', (lhs, rhs) => {`
`39`	`40`	`expect(diff(lhs, rhs)).toEqual(rhs);`
`40`	`41`	`});`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ const updatedDiff = (lhs, rhs) => {`
`10`	`10`	`const r = properObject(rhs);`
`11`	`11`
`12`	`12`	`if (isDate(l) \|\| isDate(r)) {`
`13`		`- if (l.toString() == r.toString()) return {};`
	`13`	`+ if (l.valueOf() == r.valueOf()) return {};`
`14`	`14`	`return r;`
`15`	`15`	`}`
`16`	`16`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -35,6 +35,7 @@ describe('.updatedDiff', () => {`
`35`	`35`	`[100, () => ({})],`
`36`	`36`	`[() => ({}), 100],`
`37`	`37`	`[new Date('2017年01月01日'), new Date('2017年01月02日')],`
	`38`	`+ [new Date('2017年01月01日T00:00:00.636Z'), new Date('2017年01月01日T00:00:00.637Z')],`
`38`	`39`	`]).test('returns right hand side value when different to left hand side value (%s, %s)', (lhs, rhs) => {`
`39`	`40`	`expect(updatedDiff(lhs, rhs)).toEqual(rhs);`
`40`	`41`	`});`

Comments

(0)