Commit 6fbd319

committed

fix fixmes

1 parent 81ad8f2 commit 6fbd319Copy full SHA for 6fbd319

File tree

-2

lines changed

-2

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -457,7 +457,7 @@ func checkForRouteOverlap(route L7Route, hostPortPaths map[string]string) cond`
`457`	`457`	`for _, parentRef := range route.ParentRefs {`
`458`	`458`	`if parentRef.Attachment != nil {`
`459`	`459`	`port := parentRef.Attachment.ListenerPort`
`460`		`- // FIXME(sarthyparty): https://github.com/nginx/nginx-gateway-fabric/issues/3812`
	`460`	`+ // FIXME(sarthyparty): https://github.com/nginx/nginx-gateway-fabric/issues/3811`
`461`	`461`	`// Need to merge listener hostnames with route hostnames so wildcards are handled correctly`
`462`	`462`	`// Also the AcceptedHostnames is a map of slices of strings, so we need to flatten it`
`463`	`463`	`for _, hostname := range parentRef.Attachment.AcceptedHostnames {`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ type ParentRefAttachmentStatus struct {`
`46`	`46`	`// still attach. The backendRef condition would be displayed here.`
`47`	`47`	`FailedConditions []conditions.Condition`
`48`	`48`	`// ListenerPort is the port on the Listener that the Route is attached to.`
`49`		`- // FIXME(sarthyparty): https://github.com/nginx/nginx-gateway-fabric/issues/3813`
	`49`	`+ // FIXME(sarthyparty): https://github.com/nginx/nginx-gateway-fabric/issues/3811`
`50`	`50`	`// Needs to be a map of <gatewayNamespacedName/listenerName> to port number`
`51`	`51`	`ListenerPort v1.PortNumber`
`52`	`52`	`// Attached indicates if the ParentRef is attached to the Gateway.`

Comments

(0)