-
-
Notifications
You must be signed in to change notification settings - Fork 246
Fix listview cell recycling #572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix listview cell recycling #572
Conversation
On the same note, should we change _itemTemplateSelector to itemTemplateSelector?
PRed...
I can't recall the exact reason we had to use _itemTemplatesInternal - but I do remember having issues with just itemTemplates when I implemented the ListView. It has likely been fixed in ns core since then.
topclaudy
commented
Dec 31, 2019
Is this fix released?
@topclaudy yes in an alpha release (it is safe to upgrade - I have been using the latest alpha for a while) https://github.com/nativescript-vue/nativescript-vue/releases/tag/v2.5.0-alpha.2
Fixes #565.
The
<NativeListView>was not setting theitemTemplatesproperty correctly.I am not sure why it was setting
_itemTemplatesInternalinstead ofitemTemplatesbefore, but now it works. According to my tests, the cell recycling works properly with multi-templates and the scroll is visibly smoother.For comparison of a before/after, see the updated playground app. The list on the right is patched with this fix.