Commit d60d4e1

authored

Merge pull request #139 from bananaumai/fix-type-checking-issue

fix: type check issues on encod/decode arguments

2 parents 1d5d519 + b623c69 commit d60d4e1Copy full SHA for d60d4e1

File tree

+11

-8

lines changed

+11

-8

lines changed

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,9 @@`
`1`	`1`	`/* eslint-disable @typescript-eslint/ban-types */`
`2`	`2`
`3`		`-export type SplitTypes<T, U> = U extends T ? U : Exclude<T, U>;`
	`3`	`+export type SplitTypes<T, U> = U extends T`
	`4`	`+ ? Exclude<T, U> extends never ? T : Exclude<T, U>`
	`5`	`+ : T;`
	`6`	`+`
`4`	`7`	`export type SplitUndefined<T> = SplitTypes<T, undefined>;`
`5`	`8`
`6`	`9`	`export type ContextOf<ContextType> = ContextType extends undefined`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -42,11 +42,11 @@ export const defaultDecodeOptions: DecodeOptions = {};`
`42`	`42`	`*`
`43`	`43`	* This is a synchronous decoding function. See other variants for asynchronous decoding: `decodeAsync()`, `decodeStream()`, `decodeArrayStream()`.
`44`	`44`	`*/`
`45`		`-export function decode<ContextType>(`
	`45`	`+export function decode<ContextType=undefined>(`
`46`	`46`	`buffer: ArrayLike<number> \| ArrayBuffer,`
`47`	`47`	`options: DecodeOptions<SplitUndefined<ContextType>> = defaultDecodeOptions as any,`
`48`	`48`	`): unknown {`
`49`		`- const decoder = new Decoder<ContextType>(`
	`49`	`+ const decoder = new Decoder(`
`50`	`50`	`options.extensionCodec,`
`51`	`51`	`(options as typeof options & { context: any }).context,`
`52`	`52`	`options.maxStrLength,`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ export async function decodeAsync<ContextType>(`
`9`	`9`	`): Promise<unknown> {`
`10`	`10`	`const stream = ensureAsyncIterabe(streamLike);`
`11`	`11`
`12`		`- const decoder = new Decoder<ContextType>(`
	`12`	`+ const decoder = new Decoder(`
`13`	`13`	`options.extensionCodec,`
`14`	`14`	`(options as typeof options & { context: any }).context,`
`15`	`15`	`options.maxStrLength,`
`@@ -27,7 +27,7 @@ export function decodeArrayStream<ContextType>(`
`27`	`27`	`) {`
`28`	`28`	`const stream = ensureAsyncIterabe(streamLike);`
`29`	`29`
`30`		`- const decoder = new Decoder<ContextType>(`
	`30`	`+ const decoder = new Decoder(`
`31`	`31`	`options.extensionCodec,`
`32`	`32`	`(options as typeof options & { context: any }).context,`
`33`	`33`	`options.maxStrLength,`
`@@ -46,7 +46,7 @@ export function decodeStream<ContextType>(`
`46`	`46`	`) {`
`47`	`47`	`const stream = ensureAsyncIterabe(streamLike);`
`48`	`48`
`49`		`- const decoder = new Decoder<ContextType>(`
	`49`	`+ const decoder = new Decoder(`
`50`	`50`	`options.extensionCodec,`
`51`	`51`	`(options as typeof options & { context: any }).context,`
`52`	`52`	`options.maxStrLength,`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -43,11 +43,11 @@ const defaultEncodeOptions: EncodeOptions = {};`
`43`	`43`	`*`
`44`	`44`	* The returned buffer is a slice of a larger `ArrayBuffer`, so you have to use its `#byteOffset` and `#byteLength` in order to convert it to another typed arrays including NodeJS `Buffer`.
`45`	`45`	`*/`
`46`		`-export function encode<ContextType>(`
	`46`	`+export function encode<ContextType=undefined>(`
`47`	`47`	`value: unknown,`
`48`	`48`	`options: EncodeOptions<SplitUndefined<ContextType>> = defaultEncodeOptions as any,`
`49`	`49`	`): Uint8Array {`
`50`		`- const encoder = new Encoder<ContextType>(`
	`50`	`+ const encoder = new Encoder(`
`51`	`51`	`options.extensionCodec,`
`52`	`52`	`(options as typeof options & { context: any }).context,`
`53`	`53`	`options.maxDepth,`

Comments

(0)