Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Thoughts and issues on URL scheme commands #1105

acicovic started this conversation in General
Discussion options

Hello there!

I'm running Loop 1.4.2, and noticing some issues with URL commands:

  • Running loop://screen/next or loop://screen/previous moves the window, but resizes it to a very small size.
  • Attempting to run cycles (e.g. loop://keybind/testcycle) doesn't work (cycle doesn't seem to execute) and also changes window size.
  • Running URL commands loads Loop's window.

Noting that none of these happen when using keybindings (which also feel quicker). If this would be possible, I think that URL commands should follow the exact same path as keybindings, so the behavior between them can't derive.

Relatedly, concerning instructions:

  • I wonder if we should be proposing the use of the open -g command (don't bring app to foreground) instead of plain open, which seems sluggish on my system. I've tried open -u as well in hopes that it would be faster, but it was slow.
  • FYI, URLCommandHandler.swift claims that parameters with spaces must be URL encoded. In my quick non-extensive testing, this doesn't seem required, at least if we're using quotes (which all examples use). Just wanted to bring this up in case this information isn't valid anymore for any reason.

The way I'm running the commands is through karabiner, like this:

{
 "description": "Testing Loop",
 "manipulators": [
 { "description": "Test",
 "from": {
 "simultaneous": [{ "key_code": "slash" }, { "key_code": "t" }],
 "simultaneous_options": { "key_down_order": "strict", "key_up_order": "strict_inverse" }
 },
 "parameters": { "basic.simultaneous_threshold_milliseconds": 500 },
 "to": [{ "shell_command": "open -g 'loop://screen/previous'" }],
 "type": "basic"
 }
 ]
}
You must be logged in to vote

Replies: 1 comment 2 replies

Comment options

Running URL commands loads Loop's window.

I assume this should be fixed per #1076.

You must be logged in to vote
2 replies
Comment options

Thanks for bringing this up @acicovic! You are correct, #1076 will address all the issues you mentioned above, especially the speed issues, since you’ll be able to invoke Loop’s CLI directly instead of relying on URL calls for window resizing. This also removes the need to use open -g, for the same reason. The goal is to have this included in the next stable release :)

Comment options

Thank you, looking forward to this! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants

AltStyle によって変換されたページ (->オリジナル) /