-
Notifications
You must be signed in to change notification settings - Fork 335
-
How can I make my first contribution to the bugbug repository?
Beta Was this translation helpful? Give feedback.
All reactions
Making your contribution
Ensure you have properly setup the bugbug repository on your computer. Please see #3338 if you would like to know how to properly setup the repository on your computer.
- Synchronize any changes that could have occurred before you start working on any contributions.
git checkout main git fetch upstream git merge upstream/main
- Create a branch which you shall use to make your changes/add your contribution. First time contributors can start with Issues marked as
good-first-bug. Issues are considered not assigned, until there is a PR linked to them. Feel free to work on any unassigned issue, you don't need to ask first. Remember to always use a feature_branch to mak...
Replies: 1 comment 4 replies
-
Making your contribution
Ensure you have properly setup the bugbug repository on your computer. Please see #3338 if you would like to know how to properly setup the repository on your computer.
- Synchronize any changes that could have occurred before you start working on any contributions.
git checkout main git fetch upstream git merge upstream/main
- Create a branch which you shall use to make your changes/add your contribution. First time contributors can start with Issues marked as
good-first-bug. Issues are considered not assigned, until there is a PR linked to them. Feel free to work on any unassigned issue, you don't need to ask first. Remember to always use a feature_branch to make your changes. It's good practice to never work on the main/master branch.
git checkout -b my_feature_branch_name
- Confirm you have
pre-commitinstalled on your working environment by running:
pre-commit -V #Output should be pre-commit versionpre-commitruns checks on your code before a commit thus improves the quality of commits. It should have been installed when you ran the commandpip install -r test-requirements.txtfrom the Setup and Prerequisities inREADME.md
- Make your changes on your feature branch and when you are done editing, add the changed files and commit them.
git add modified_file git commit -m "Type a nice commit message"
pre-commitwill run code style checks whenever you commit your changes and if all checks have passed, the commit will complete.
- Push the changes to your forked repository (origin) on your GitHub Account:
git push -u origin my_feature_branch_name
- Make a pull request on Github. You can follow this guide on how to make a pull request from a forked repository. Please also see Submitting a Pull Request (PR) #3340 on how to submit your pull request to
bugbug
Beta Was this translation helpful? Give feedback.
All reactions
-
Hi @jpangas , how are you?
when I ran the pre-commit the output was pre-commit 3.4.0, is this normal?
Beta Was this translation helpful? Give feedback.
All reactions
-
Currently bugbug uses version 3.5.0. Have you pulled the latest changes from the repository?
Beta Was this translation helpful? Give feedback.
All reactions
-
Yes, I updated my master branch with git fetch upstream and git merge upstream/master
I went to the branch where I want to make the changes and to verify I used git diff, and there is no difference.
pre-commit -V outputs pre-commit 3.4.0
Beta Was this translation helpful? Give feedback.
All reactions
-
@AngieMeliss the version for pre-commit is not a big deal. Anyway, you could update it if you want by installing the test dependencies:
pip install -r test-requirements.txt
Beta Was this translation helpful? Give feedback.