-
Notifications
You must be signed in to change notification settings - Fork 335
-
How can I submit a PR? What should I follow before submitting the PR and is there anything else I should do after submitting the Pull Request?
Beta Was this translation helpful? Give feedback.
All reactions
Answered by
jpangas
Mar 8, 2023
Checklist when submitting your PR
- The PR needs to be approved by the bugbug maintainers. In order to ease the review process, it is recommended you follow these principles:
- Let the PR have a helpful title and descriptive body.
- Link your PR to the issue it is solving, closing or resolving using
Fixes/Closes/Resolves #PRNumber - Ensure your changes have produced no code style or linting errors.
pre-commitwill run these checks. If any issues are found, the tests will fail.
After submitting your PR
- Allow time for the reviewer to review your changes and if any further changes are needed, make and commit those changes to the same feature_name_branch.
The bugbug maintainers will check the c...
Replies: 1 comment
-
Checklist when submitting your PR
- The PR needs to be approved by the bugbug maintainers. In order to ease the review process, it is recommended you follow these principles:
- Let the PR have a helpful title and descriptive body.
- Link your PR to the issue it is solving, closing or resolving using
Fixes/Closes/Resolves #PRNumber - Ensure your changes have produced no code style or linting errors.
pre-commitwill run these checks. If any issues are found, the tests will fail.
After submitting your PR
- Allow time for the reviewer to review your changes and if any further changes are needed, make and commit those changes to the same feature_name_branch.
The bugbug maintainers will check the changes, and if everything is looking good, they will approve and merge the changes to the main branch of the bugbug repository.
- After the changes have been merged, to the bugbug master repository, you can delete the feature_branch on your forked repository. Checkout to the main (sometimes called master) branch on your machine and then pull the latest changes.
git checkout main git fetch upstream git merge upstream/main
- Sync the updated main on your machine back to your fork.
git push -u origin main
- You are free to work on any other issue and/or make further contributions.
For further assistance or discussions:
Chat with us in the bugbug Matrix room.
Beta Was this translation helpful? Give feedback.
All reactions
0 replies
Answer selected by
jpangas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment