Commit b0ccd0e

jteichcomandeo-mongo

and

authored

RUBY-3604 Fix multithread auth race condition (#2912)

Co-authored-by: Dmitry Rybakov <dmitry.rybakov@mongodb.com>

1 parent 0e91a40 commit b0ccd0eCopy full SHA for b0ccd0e

File tree

+13

-6

lines changed

+13

-6

lines changed

Lines changed: 13 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -22,19 +22,24 @@ module Auth`
`22`	`22`	`#`
`23`	`23`	`# @api private`
`24`	`24`	`module CredentialCache`
`25`		`-`
`26`	`25`	`class << self`
`27`	`26`	`attr_reader :store`
`28`	`27`	`end`
`29`	`28`
	`29`	`+ MUTEX = Mutex.new`
	`30`	`+`
`30`	`31`	`module_function def get(key)`
`31`		`- @store \|\|= {}`
`32`		`- @store[key]`
	`32`	`+ MUTEX.synchronize do`
	`33`	`+ @store \|\|= {}`
	`34`	`+ @store[key]`
	`35`	`+ end`
`33`	`36`	`end`
`34`	`37`
`35`	`38`	`module_function def set(key, value)`
`36`		`- @store \|\|= {}`
`37`		`- @store[key] = value`
	`39`	`+ MUTEX.synchronize do`
	`40`	`+ @store \|\|= {}`
	`41`	`+ @store[key] = value`
	`42`	`+ end`
`38`	`43`	`end`
`39`	`44`
`40`	`45`	`module_function def cache(key)`
`@@ -47,7 +52,9 @@ class << self`
`47`	`52`	`end`
`48`	`53`
`49`	`54`	`module_function def clear`
`50`		`- @store = {}`
	`55`	`+ MUTEX.synchronize do`
	`56`	`+ @store = {}`
	`57`	`+ end`
`51`	`58`	`end`
`52`	`59`	`end`
`53`	`60`	`end`

Comments

(0)