Commit cf7a1aa

authored

PYTHON-5504 Prototype exponential backoff in with_transaction (#2492)

1 parent e4b7eb5 commit cf7a1aaCopy full SHA for cf7a1aa

File tree

+19

-0

lines changed

+19

-0

lines changed

Lines changed: 10 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -135,7 +135,9 @@`
`135`	`135`
`136`	`136`	`from __future__ import annotations`
`137`	`137`
	`138`	`+import asyncio`
`138`	`139`	`import collections`
	`140`	`+import random`
`139`	`141`	`import time`
`140`	`142`	`import uuid`
`141`	`143`	`from collections.abc import Mapping as _Mapping`
`@@ -471,6 +473,8 @@ def _max_time_expired_error(exc: PyMongoError) -> bool:`
`471`	`473`	`# This limit is non-configurable and was chosen to be twice the 60 second`
`472`	`474`	# default value of MongoDB's `transactionLifetimeLimitSeconds` parameter.
`473`	`475`	`_WITH_TRANSACTION_RETRY_TIME_LIMIT = 120`
	`476`	`+_BACKOFF_MAX = 1`
	`477`	`+_BACKOFF_INITIAL = 0.050 # 50ms initial backoff`
`474`	`478`
`475`	`479`
`476`	`480`	`def _within_time_limit(start_time: float) -> bool:`
`@@ -700,7 +704,13 @@ async def callback(session, custom_arg, custom_kwarg=None):`
`700`	`704`	`https://github.com/mongodb/specifications/blob/master/source/transactions-convenient-api/transactions-convenient-api.md#handling-errors-inside-the-callback`
`701`	`705`	`"""`
`702`	`706`	`start_time = time.monotonic()`
	`707`	`+ retry = 0`
`703`	`708`	`while True:`
	`709`	`+ if retry: # Implement exponential backoff on retry.`
	`710`	`+ jitter = random.random() # noqa: S311`
	`711`	`+ backoff = jitter * min(_BACKOFF_INITIAL * (2**retry), _BACKOFF_MAX)`
	`712`	`+ await asyncio.sleep(backoff)`
	`713`	`+ retry += 1`
`704`	`714`	`await self.start_transaction(`
`705`	`715`	`read_concern, write_concern, read_preference, max_commit_time_ms`
`706`	`716`	`)`

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -136,6 +136,7 @@`
`136`	`136`	`from __future__ import annotations`
`137`	`137`
`138`	`138`	`import collections`
	`139`	`+import random`
`139`	`140`	`import time`
`140`	`141`	`import uuid`
`141`	`142`	`from collections.abc import Mapping as _Mapping`
`@@ -470,6 +471,8 @@ def _max_time_expired_error(exc: PyMongoError) -> bool:`
`470`	`471`	`# This limit is non-configurable and was chosen to be twice the 60 second`
`471`	`472`	# default value of MongoDB's `transactionLifetimeLimitSeconds` parameter.
`472`	`473`	`_WITH_TRANSACTION_RETRY_TIME_LIMIT = 120`
	`474`	`+_BACKOFF_MAX = 1`
	`475`	`+_BACKOFF_INITIAL = 0.050 # 50ms initial backoff`
`473`	`476`
`474`	`477`
`475`	`478`	`def _within_time_limit(start_time: float) -> bool:`
`@@ -699,7 +702,13 @@ def callback(session, custom_arg, custom_kwarg=None):`
`699`	`702`	`https://github.com/mongodb/specifications/blob/master/source/transactions-convenient-api/transactions-convenient-api.md#handling-errors-inside-the-callback`
`700`	`703`	`"""`
`701`	`704`	`start_time = time.monotonic()`
	`705`	`+ retry = 0`
`702`	`706`	`while True:`
	`707`	`+ if retry: # Implement exponential backoff on retry.`
	`708`	`+ jitter = random.random() # noqa: S311`
	`709`	`+ backoff = jitter * min(_BACKOFF_INITIAL * (2**retry), _BACKOFF_MAX)`
	`710`	`+ time.sleep(backoff)`
	`711`	`+ retry += 1`
`703`	`712`	`self.start_transaction(read_concern, write_concern, read_preference, max_commit_time_ms)`
`704`	`713`	`try:`
`705`	`714`	`ret = callback(self)`

Comments

(0)