Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit 3ebd934

Browse files
PYTHON-5514 Specific assertions for "is" and "is not None" (#2502)
1 parent ddf9508 commit 3ebd934

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

‎test/asynchronous/test_collection.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1319,7 +1319,7 @@ async def test_error_code(self):
13191319
self.assertIn(exc.code, (9, 10147, 16840, 17009))
13201320
# Just check that we set the error document. Fields
13211321
# vary by MongoDB version.
1322-
self.assertTrue(exc.detailsisnotNone)
1322+
self.assertIsNotNone(exc.details)
13231323
else:
13241324
self.fail("OperationFailure was not raised")
13251325

‎test/asynchronous/test_session.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -378,9 +378,9 @@ async def test_cursor_clone(self):
378378

379379
async with self.client.start_session() as s:
380380
cursor = coll.find(session=s)
381-
self.assertTrue(cursor.sessionis s)
381+
self.assertIs(cursor.session, s)
382382
clone = cursor.clone()
383-
self.assertTrue(clone.sessionis s)
383+
self.assertIs(clone.session, s)
384384

385385
# No explicit session.
386386
cursor = coll.find(batch_size=2)
@@ -392,7 +392,7 @@ async def test_cursor_clone(self):
392392
await anext(clone)
393393
self.assertIsNone(clone.session)
394394
self.assertIsNotNone(clone._session)
395-
self.assertFalse(cursor._sessionis clone._session)
395+
self.assertIsNot(cursor._session, clone._session)
396396
await cursor.close()
397397
await clone.close()
398398

‎test/test_collection.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1305,7 +1305,7 @@ def test_error_code(self):
13051305
self.assertIn(exc.code, (9, 10147, 16840, 17009))
13061306
# Just check that we set the error document. Fields
13071307
# vary by MongoDB version.
1308-
self.assertTrue(exc.detailsisnotNone)
1308+
self.assertIsNotNone(exc.details)
13091309
else:
13101310
self.fail("OperationFailure was not raised")
13111311

‎test/test_session.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -378,9 +378,9 @@ def test_cursor_clone(self):
378378

379379
with self.client.start_session() as s:
380380
cursor = coll.find(session=s)
381-
self.assertTrue(cursor.sessionis s)
381+
self.assertIs(cursor.session, s)
382382
clone = cursor.clone()
383-
self.assertTrue(clone.sessionis s)
383+
self.assertIs(clone.session, s)
384384

385385
# No explicit session.
386386
cursor = coll.find(batch_size=2)
@@ -392,7 +392,7 @@ def test_cursor_clone(self):
392392
next(clone)
393393
self.assertIsNone(clone.session)
394394
self.assertIsNotNone(clone._session)
395-
self.assertFalse(cursor._sessionis clone._session)
395+
self.assertIsNot(cursor._session, clone._session)
396396
cursor.close()
397397
clone.close()
398398

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /