Commit 5832007

authored

Remove manual dirty _id check when updating a model (#3329)

1 parent 1265bb1 commit 5832007Copy full SHA for 5832007

File tree

+42

-7

lines changed

+42

-7

lines changed

Lines changed: 0 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -783,13 +783,6 @@ public function update(array $values, array $options = [])`
`783`	`783`	`unset($values[$key]);`
`784`	`784`	`}`
`785`	`785`
`786`		`- // Since "id" is an alias for "_id", we prevent updating it`
`787`		`- foreach ($values as $fields) {`
`788`		`- if (array_key_exists('id', $fields)) {`
`789`		`- throw new InvalidArgumentException('Cannot update "id" field.');`
`790`		`- }`
`791`		`- }`
`792`		`-`
`793`	`786`	`return $this->performUpdate($values, $options);`
`794`	`787`	`}`
`795`	`788`

Lines changed: 42 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,42 @@`
	`1`	`+<?php`
	`2`	`+`
	`3`	`+declare(strict_types=1);`
	`4`	`+`
	`5`	`+namespace MongoDB\Laravel\Tests\Ticket;`
	`6`	`+`
	`7`	`+use MongoDB\Laravel\Eloquent\Model;`
	`8`	`+use MongoDB\Laravel\Tests\TestCase;`
	`9`	`+`
	`10`	`+/**`
	`11`	`+ * @see https://github.com/mongodb/laravel-mongodb/issues/3326`
	`12`	`+ * @see https://jira.mongodb.org/browse/PHPORM-309`
	`13`	`+ */`
	`14`	`+class GH3326Test extends TestCase`
	`15`	`+{`
	`16`	`+ public function testCreatedEventCanSafelyCallSave(): void`
	`17`	`+ {`
	`18`	`+ $model = new GH3326Model();`
	`19`	`+ $model->foo = 'bar';`
	`20`	`+ $model->save();`
	`21`	`+`
	`22`	`+ $fresh = $model->fresh();`
	`23`	`+`
	`24`	`+ $this->assertEquals('bar', $fresh->foo);`
	`25`	`+ $this->assertEquals('written-in-created', $fresh->extra);`
	`26`	`+ }`
	`27`	`+}`
	`28`	`+`
	`29`	`+class GH3326Model extends Model`
	`30`	`+{`
	`31`	`+ protected $connection = 'mongodb';`
	`32`	`+ protected $collection = 'test_gh3326';`
	`33`	`+ protected $guarded = [];`
	`34`	`+`
	`35`	`+ protected static function booted(): void`
	`36`	`+ {`
	`37`	`+ static::created(function ($model) {`
	`38`	`+ $model->extra = 'written-in-created';`
	`39`	`+ $model->saveQuietly();`
	`40`	`+ });`
	`41`	`+ }`
	`42`	`+}`

Comments

(0)