This repository was archived by the owner on Dec 22, 2021. It is now read-only.

Commit 054f48b

committed

PERL-1123 Raise better error for retryable writes with mmapv1

1 parent 71de231 commit 054f48bCopy full SHA for 054f48b

File tree

+16

-0

lines changed

+16

-0

lines changed

Lines changed: 10 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -49,6 +49,7 @@ BEGIN {`
`49`	`49`	`HOST_NOT_FOUND => 7,`
`50`	`50`	`UNKNOWN_ERROR => 8,`
`51`	`51`	`USER_NOT_FOUND => 11,`
	`52`	`+ ILLEGAL_OPERATION => 20,`
`52`	`53`	`NAMESPACE_NOT_FOUND => 26,`
`53`	`54`	`INDEX_NOT_FOUND => 27,`
`54`	`55`	`CURSOR_NOT_FOUND => 43,`
`@@ -239,6 +240,15 @@ sub _is_transient_transaction_error {`
`239`	`240`	`return 0;`
`240`	`241`	`}`
`241`	`242`
	`243`	`+# Look for error code ILLEGAL_OPERATION and starts with "Transaction numbers"`
	`244`	`+sub _is_storage_engine_not_retryable {`
	`245`	`+ my $self = shift;`
	`246`	`+ if ( $self->$_can( 'code' ) ) {`
	`247`	`+ return 0 if $self->code != MongoDB::Error::ILLEGAL_OPERATION;`
	`248`	`+ }`
	`249`	`+ return index($self->message, "Transaction numbers", 0) == 0;`
	`250`	`+}`
	`251`	`+`
`242`	`252`	`#--------------------------------------------------------------------------#`
`243`	`253`	`# Subclasses with attributes included inline below`
`244`	`254`	`#--------------------------------------------------------------------------#`

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -170,6 +170,12 @@ sub send_retryable_write_op {`
`170`	`170`	`eval { ($result) = $self->_try_op_for_link( $link, $op ); 1 } or do {`
`171`	`171`	`my $err = length($@) ? $@ : "caught error, but it was lost in eval unwind";`
`172`	`172`
	`173`	`+ if ( $err->$_call_if_can('_is_storage_engine_not_retryable') ) {`
	`174`	`+ # Break encapsulation to rewrite the message, then rethrow.`
	`175`	`+ $err->{message} = "This MongoDB deployment does not support retryable writes. Please add retryWrites=false to your connection string.";`
	`176`	`+ die $err;`
	`177`	`+ }`
	`178`	`+`
`173`	`179`	`# If the error is not retryable, then drop out`
`174`	`180`	`unless ( $err->$_call_if_can('_is_retryable') ) {`
`175`	`181`	`WITH_ASSERTS ? ( confess $err ) : ( die $err );`

Comments

(0)