Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Commit c46c1b9

Browse files
feat(NODE-7170)!: drop support for Nodejs <20.19.0 (#92)
1 parent f67cb71 commit c46c1b9

File tree

10 files changed

+15
-31
lines changed

10 files changed

+15
-31
lines changed

‎.eslintrc.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"es6": true
1414
},
1515
"parserOptions": {
16-
"ecmaVersion": 2019
16+
"ecmaVersion": 2023
1717
},
1818
"plugins": [
1919
"@typescript-eslint",
@@ -82,4 +82,4 @@
8282
}
8383
}
8484
]
85-
}
85+
}

‎.github/dependabot.yml‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,6 @@ updates:
2020
# sinon-chai 4.x+ supports chai 5.x+.
2121
- dependency-name: "sinon-chai"
2222
versions: [">=4.0.0"]
23-
# nyc is Node18+ only starting on nyc@16.x.
24-
- dependency-name: "nyc"
25-
versions: [">=16.0.0"]
2623
# we ignore TS as a part of quarterly dependency updates.
2724
- dependency-name: "typescript"
2825
# node-gyp now depends on python 3.10, we install 3.6 in our dockerfile

‎.github/docker/Dockerfile.glibc‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
1-
ARG UBUNTU_VERSION=bionic
2-
FROM ubuntu:${UBUNTU_VERSION} AS build
1+
FROM ubuntu:noble AS build
32

4-
ARG NODE_VERSION=16.20.1
3+
ARG NODE_VERSION=20.19.0
54
# Possible values: s390x, arm64, x64
65
ARG NODE_ARCH
76
ADD https://nodejs.org/dist/v${NODE_VERSION}/node-v${NODE_VERSION}-linux-${NODE_ARCH}.tar.gz /

‎.github/docker/Dockerfile.musl‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
ARG PLATFORM=arm64
2-
ARG NODE_VERSION=16.20.1
2+
ARG NODE_VERSION=20.19.0
33

44
FROM ${PLATFORM}/node:${NODE_VERSION}-alpine AS build
55

‎.github/workflows/build.yml‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -79,12 +79,6 @@ jobs:
7979
steps:
8080
- uses: actions/checkout@v4
8181

82-
- name: Get Full Node.js Version
83-
id: get_nodejs_version
84-
shell: bash
85-
run: |
86-
echo "version=$(node --print 'process.version.slice(1)')" >> "$GITHUB_OUTPUT"
87-
8882
- name: Set up QEMU
8983
uses: docker/setup-qemu-action@v3
9084

‎.github/workflows/test.yml‎

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212
strategy:
1313
matrix:
1414
os: [macos-latest, windows-2022]
15-
node: [16.x, 18.x, 20.x, 22.x]
15+
node: [20.19.0, 22.x]
1616
fail-fast: false
1717
runs-on: ${{ matrix.os }}
1818
steps:
@@ -37,7 +37,7 @@ jobs:
3737
strategy:
3838
matrix:
3939
linux_arch: [s390x, arm64, amd64]
40-
node: [16.x, 18.x, 20.x, 22.x]
40+
node: [20.19.0, 22.x]
4141
fail-fast: false
4242
steps:
4343
- uses: actions/checkout@v4
@@ -51,7 +51,6 @@ jobs:
5151
shell: bash
5252
run: |
5353
echo "version=$(node --print 'process.version.slice(1)')" >> "$GITHUB_OUTPUT"
54-
echo "ubuntu_version=$(node --print '(+process.version.slice(1).split(`.`).at(0)) > 16 ? `noble` : `bionic`')" >> "$GITHUB_OUTPUT"
5554
5655
- name: Set up QEMU
5756
uses: docker/setup-qemu-action@v3
@@ -66,19 +65,17 @@ jobs:
6665
--platform linux/${{ matrix.linux_arch }} \
6766
--build-arg="NODE_ARCH=${{ matrix.linux_arch == 'amd64' && 'x64' || matrix.linux_arch }}" \
6867
--build-arg="NODE_VERSION=${{ steps.get_nodejs_version.outputs.version }}" \
69-
--build-arg="UBUNTU_VERSION=${{ steps.get_nodejs_version.outputs.ubuntu_version }}" \
7068
--build-arg="RUN_TEST=true" \
7169
--output type=local,dest=./prebuilds,platform-split=false \
7270
-f ./.github/docker/Dockerfile.glibc \
7371
.
7472
75-
7673
container_tests_musl:
7774
runs-on: ubuntu-latest
7875
strategy:
7976
matrix:
8077
linux_arch: [amd64, arm64]
81-
node: [16.20.1, 18.x, 20.x, 22.x]
78+
node: [20.19.0, 22.x]
8279
fail-fast: false
8380
steps:
8481
- uses: actions/checkout@v4

‎etc/docker.sh‎

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77
# amd64 or arm64v8 for alpine
88
LINUX_ARCH=amd64
99

10-
# 16.20.1+, default 16.20.1
11-
NODE_VERSION=20.0.0
10+
# 20.19.0+, default 20.19.0
11+
NODE_VERSION=20.19.0
1212

1313
SCRIPT_DIR=$(dirname ${BASH_SOURCE:-0ドル})
1414
PROJECT_DIR=$SCRIPT_DIR/..
@@ -28,14 +28,11 @@ build_and_test_musl() {
2828
build_and_test_glibc() {
2929
docker buildx create --name builder --bootstrap --use
3030

31-
UBUNTU_VERSION=$(node --print 'Number(process.argv[1].split(`.`).at(0)) > 16 ? `noble` : `bionic`' $NODE_VERSION)
3231
NODE_ARCH=$(node -p 'process.argv[1] === `amd64` && `x64` || process.argv[1]' $LINUX_ARCH)
33-
echo $UBUNTU_VERSION
3432
docker buildx build --progress=plain --no-cache \
3533
--platform linux/$LINUX_ARCH \
3634
--build-arg="NODE_ARCH=$NODE_ARCH" \
3735
--build-arg="NODE_VERSION=$NODE_VERSION" \
38-
--build-arg="UBUNTU_VERSION=$UBUNTU_VERSION" \
3936
--build-arg="RUN_TEST=true" \
4037
--output type=local,dest=./prebuilds,platform-split=false \
4138
-f ./.github/docker/Dockerfile.glibc \

‎package-lock.json‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@
7676
}
7777
},
7878
"engines": {
79-
"node": ">=16.20.1"
79+
"node": ">=20.19.0"
8080
},
8181
"binary": {
8282
"napi_versions": [

‎tsconfig.json‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,13 @@
44
"checkJs": false,
55
"strict": true,
66
"alwaysStrict": true,
7-
"target": "ES2020",
7+
"target": "ES2023",
88
"module": "commonJS",
99
"moduleResolution": "node",
1010
"skipLibCheck": true,
1111
"erasableSyntaxOnly": true,
1212
"lib": [
13-
"es2020", "es2021.WeakRef"
13+
"es2023"
1414
],
1515
// We don't make use of tslib helpers, all syntax used is supported by target engine
1616
"importHelpers": false,
@@ -43,4 +43,4 @@
4343
"include": [
4444
"src/**/*"
4545
]
46-
}
46+
}

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /