-
Notifications
You must be signed in to change notification settings - Fork 232
-
The two methods delete
and forceDelete
in Buildable
trait should imho only flush the cache, if the parent methods return an int > 0. Right now, the cache is flushed every time, even when the query did not actually deleted records from the database.
public function delete()
{
$result = parent::delete();
if ($result) {
$this->cache($this->makeCacheTags())->flush();
}
return $result;
}
Beta Was this translation helpful? Give feedback.
All reactions
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment