Commit 006271f

author

Charlie Barto

committed

make Uri.is_host_loopback() only return true for localhost and 127.0.0.1 exactly

1 parent 9c65488 commit 006271fCopy full SHA for 006271f

File tree

-3

lines changed

-3

lines changed

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -296,13 +296,14 @@ class uri`
`296`	`296`	`/// A loopback URI is one which refers to a hostname or ip address with meaning only on the local machine.`
`297`	`297`	`/// </summary>`
`298`	`298`	`/// <remarks>`
`299`		`- /// Examples include "localhost", or ip addresses in the loopback range (127.0.0.0/24).`
	`299`	`+ /// Examples include "localhost", or "127.0.0.1". The only URIs for which this method returns true are "127.0.0.1", and "localhost",`
	`300`	`+ /// all other URIs return false`
`300`	`301`	`/// </remarks>`
`301`	`302`	`/// <returns><c>true</c> if this URI references the local host, <c>false</c> otherwise.</returns>`
`302`	`303`	`bool is_host_loopback() const`
`303`	`304`	`{`
`304`	`305`	`return !is_empty() &&`
`305`		`- ((host() == _XPLATSTR("localhost")) \|\| (host().size() > 4 && host().substr(0, 4) == _XPLATSTR("127.")));`
	`306`	`+ ((host() == _XPLATSTR("localhost")) \|\| (host()== _XPLATSTR("127.0.0.1")));`
`306`	`307`	`}`
`307`	`308`
`308`	`309`	`/// <summary>`

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -24,6 +24,11 @@ namespace uri_tests`
`24`	`24`	`{`
`25`	`25`	`SUITE(constructor_tests)`
`26`	`26`	`{`
	`27`	`+ TEST(not_really_a_loopback_uri)`
	`28`	`+ {`
	`29`	`+ uri u(uri::encode_uri(U("https://127.evil.com")));`
	`30`	`+ VERIFY_IS_FALSE(u.is_host_loopback());`
	`31`	`+ }`
`27`	`32`	`TEST(parsing_constructor_char)`
`28`	`33`	`{`
`29`	`34`	`uri u(uri::encode_uri(U("net.tcp://steve:@testname.com:81/bleh%?qstring#goo")));`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,7 @@ SUITE(diagnostic_tests)`
`82`	`82`	`VERIFY_IS_FALSE(uri(U("http://bleh/?qstring")).is_host_loopback());`
`83`	`83`	`VERIFY_IS_FALSE(uri(U("http://+*/?qstring")).is_host_loopback());`
`84`	`84`	`VERIFY_IS_TRUE(uri(U("http://127.0.0.1/")).is_host_loopback());`
`85`		`- VERIFY_IS_TRUE(uri(U("http://127.155.0.1/")).is_host_loopback());`
	`85`	`+ VERIFY_IS_FALSE(uri(U("http://127.155.0.1/")).is_host_loopback());`
`86`	`86`	`VERIFY_IS_FALSE(uri(U("http://128.0.0.1/")).is_host_loopback());`
`87`	`87`	`}`
`88`	`88`

Comments

(0)