Commit 2c2e30c

authored

Merge pull request #901 from maheini/prevent_empty_username

prevent empty username on dbauth register endpoint

2 parents fa7e60e + c816bff commit 2c2e30cCopy full SHA for 2c2e30c

File tree

-0

lines changed

src/Tqdev/PhpCrudApi
- Middleware
  - DbAuthMiddleware.php
- Record
  - ErrorCode.php

-0

lines changed

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -77,6 +77,9 @@ public function process(ServerRequestInterface $request, RequestHandlerInterface`
`77`	`77`	`if (!$registerUser) {`
`78`	`78`	`return $this->responder->error(ErrorCode::AUTHENTICATION_FAILED, $username);`
`79`	`79`	`}`
	`80`	`+ if(strlen(trim($username)) == 0){`
	`81`	`+ return $this->responder->error(ErrorCode::USERNAME_EMPTY, $username);`
	`82`	`+ }`
`80`	`83`	`if (strlen($password) < $passwordLength) {`
`81`	`84`	`return $this->responder->error(ErrorCode::PASSWORD_TOO_SHORT, $passwordLength);`
`82`	`85`	`}`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -33,6 +33,7 @@ class ErrorCode`
`33`	`33`	`const PAGINATION_FORBIDDEN = 1019;`
`34`	`34`	`const USER_ALREADY_EXIST = 1020;`
`35`	`35`	`const PASSWORD_TOO_SHORT = 1021;`
	`36`	`+ const USERNAME_EMPTY = 1022;`
`36`	`37`
`37`	`38`	`private $values = [`
`38`	`39`	`0000 => ["Success", ResponseFactory::OK],`
`@@ -58,6 +59,7 @@ class ErrorCode`
`58`	`59`	`1019 => ["Pagination forbidden", ResponseFactory::FORBIDDEN],`
`59`	`60`	`1020 => ["User '%s' already exists", ResponseFactory::CONFLICT],`
`60`	`61`	`1021 => ["Password too short (<%d characters)", ResponseFactory::UNPROCESSABLE_ENTITY],`
	`62`	`+ 1022 => ["Username is empty or only whitespaces", ResponseFactory::UNPROCESSABLE_ENTITY],`
`61`	`63`	`9999 => ["%s", ResponseFactory::INTERNAL_SERVER_ERROR],`
`62`	`64`	`];`
`63`	`65`

Comments

(0)