Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add instructions for how to run tests in readme #357

Open

Description

Hi,

I am interested in exploring the existing tests and writing some new ones to check behaviour with React 18 and concurrency. I am on an M1 MacBook and needed to update Meteor so that may be the root of my issues. I can copy the tests out of this repository and they run though so I may also be misunderstanding how they should be run.

I have tried:

cd tests/react-meteor-data-harness
meteor npm install
meteor npm test

This required manually meteor npm install @babel/runtime jquery and ultimately errors in the browser with - exception - message Can't find variable: ReactMeteorData

Next approach also from tests/react-meteor-data-harness:

PACKAGE_DIRS=../../packages meteor test-packages // Errored with missing dev packages
meteor npm i --save-dev @testing-library/react@^12.0.0 @testing-library/react-hooks
PACKAGE_DIRS=../../packages meteor test-packages // Test results in browser but all fail 
meteor npm I --save react@^17.0.0 react-dom@^17.0.0 
PACKAGE_DIRS=../../packages meteor test-packages

Ultimately getting many green tests but hanging indefinitely in useTracker resubscribe tests.

My thought is that with many permutations of running npm install, npm test, meteor test, and meteor test-packages at various directory levels it would be helpful to add a few sentences describing a combination that is expected to work. A link to a CI script that run the tests would also be helpful if one exists.

It may be that the correct path is meant to be:

cd tests/react-meteor-data-harness
meteor npm install
meteor npm test
PACKAGE_DIRS=../../packages meteor test-packages

And all my problems stem from M1 and the Meteor update resulting in missing dependencies. If so I am happy to make a pull request adding these instructions and ignoring my update journey. Adding a package.json script to run the package tests would also simplify and clarify the process.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

        AltStyle によって変換されたページ (->オリジナル) /