Commit b762198

JeromeDeLeonafontcu

and

authored

feat: Add support for input file on fireEvent.update (testing-library#179)

* add input file fail test * fix incorrect render * add input file to update fireEvent * Update based on suggestion Co-authored-by: Adrià Fontcuberta <afontcu@gmail.com>

1 parent a051013 commit b762198Copy full SHA for b762198

File tree

2 files changed

+23

-0

lines changed

src
- __tests__
  - fire-event.js
- vue-testing-library.js

2 files changed

+23

-0

lines changed

`‎src/tests/fire-event.js`

Lines changed: 21 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -119,6 +119,7 @@ const eventTypes = [`
`119`	`119`	`elementType: 'div',`
`120`	`120`	`},`
`121`	`121`	`]`
	`122`	`+`
`122`	`123`	`beforeEach(() => {`
`123`	`124`	`jest.spyOn(console, 'warn').mockImplementation(() => {})`
`124`	`125`	`})`
`@@ -215,6 +216,26 @@ test('fireEvent.update does not trigger warning messages', async () => {`
`215`	`216`	`expect(console.warn).not.toHaveBeenCalled()`
`216`	`217`	`})`
`217`	`218`
	`219`	`+test('fireEvent.update should not crash with input file', async () => {`
	`220`	`+ const {getByTestId} = render({`
	`221`	+ template: `<input type="file" data-testid="test-update" />`,
	`222`	`+ })`
	`223`	`+`
	`224`	`+ const file = new File(['(⌐□しろいしかく_□しろいしかく)'], 'chucknorris.png', {type: 'image/png'})`
	`225`	`+`
	`226`	`+ const inputEl = getByTestId('test-update')`
	`227`	`+`
	`228`	`+ // You could replace the lines below with`
	`229`	`+ // userEvent.upload(inputEl, file)`
	`230`	`+ Object.defineProperty(inputEl, 'files', {`
	`231`	`+ value: [file],`
	`232`	`+ })`
	`233`	`+`
	`234`	`+ await fireEvent.update(inputEl)`
	`235`	`+`
	`236`	`+ expect(console.warn).not.toHaveBeenCalled()`
	`237`	`+})`
	`238`	`+`
`218`	`239`	`test('fireEvent.update does not crash if non-input element is passed in', async () => {`
`219`	`240`	`const {getByText} = render({`
`220`	`241`	template: `<div>Hi</div>`,

`‎src/vue-testing-library.js`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -158,6 +158,8 @@ fireEvent.update = (elem, value) => {`
`158`	`158`	`if (['checkbox', 'radio'].includes(type)) {`
`159`	`159`	`elem.checked = true`
`160`	`160`	`return fireEvent.change(elem)`
	`161`	`+ } else if (type === 'file') {`
	`162`	`+ return fireEvent.change(elem)`
`161`	`163`	`} else {`
`162`	`164`	`elem.value = value`
`163`	`165`	`if (elem._vModifiers && elem._vModifiers.lazy) {`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit b762198

File tree

2 files changed

2 files changed

`‎src/tests/fire-event.js`

`‎src/vue-testing-library.js`

0 commit comments

File tree

2 files changed

2 files changed

‎src/__tests__/fire-event.js

‎src/vue-testing-library.js

0 commit comments

`‎src/tests/fire-event.js`

`‎src/vue-testing-library.js`