Commit 4376e64

authored

feat: Add env to turn off fireEvent.update warning (testing-library#181)

* add env to turn off warning: `VTL_SKIP_WARN_EVENT_UPDATE`

1 parent 8ddeac6 commit 4376e64Copy full SHA for 4376e64

File tree

+16

-1

lines changed

+16

-1

lines changed

Lines changed: 12 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -229,3 +229,15 @@ test('fireEvent.update does not crash if non-input element is passed in', async`
`229`	`229`	`)
`230`	`230`	`expect(console.warn).not.toHaveBeenCalled()`
`231`	`231`	`})`
	`232`	`+`
	`233`	`+test('fireEvent change/input should not throw warning when env is set', async () => {`
	`234`	`+ process.env.VTL_SKIP_WARN_EVENT_UPDATE = 'true'`
	`235`	`+ const {getByTestId} = render({`
	`236`	+ template: `<input type="text" data-testid=test-input></input>`,
	`237`	`+ })`
	`238`	`+`
	`239`	`+ await fireEvent.input(getByTestId('test-input'), {target: {value: 'hello'}})`
	`240`	`+ await fireEvent.change(getByTestId('test-input'), {target: {value: 'hello'}})`
	`241`	`+`
	`242`	`+ expect(console.warn).not.toHaveBeenCalled()`
	`243`	`+})`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -117,7 +117,10 @@ const changeOrInputEventCalledDirectly = (eventValue, eventKey) =>`
`117`	`117`
`118`	`118`	`Object.keys(dtlFireEvent).forEach(key => {`
`119`	`119`	`fireEvent[key] = async (...args) => {`
`120`		`- if (changeOrInputEventCalledDirectly(args[1], key)) {`
	`120`	`+ if (`
	`121`	`+ changeOrInputEventCalledDirectly(args[1], key) &&`
	`122`	`+ !process.env.VTL_SKIP_WARN_EVENT_UPDATE`
	`123`	`+ ) {`
`121`	`124`	`console.warn(`
`122`	`125`	`Using "fireEvent.${key} may lead to unexpected results. Please use fireEvent.update() instead.`,
`123`	`126`	`)`

Comments

(0)